Add equivalence testing on JS nodes to support different label names

Add equivalence testing on JS nodes to support different label names

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/3433c71c2ead38a994b39fe254933669995c5b4d

[Johnni Winther, 2017-06-30 20:26:43]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-06-30 22:24:01]

should the equivalence checks for js-asts should move into
package:js_ast/testing?

https://codereview.chromium.org/2963193003/diff/1/tests/compiler/dart2js/kern...
File tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart (left):

https://codereview.chromium.org/2963193003/diff/1/tests/compiler/dart2js/kern...
tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart:92: //if (i ==
5) continue;
did you mean to keep the `if (i == 5) continue;` statement?

[sra1, 2017-06-30 22:57:47]

sra@google.com changed reviewers:
+ sra@google.com

[sra1, 2017-06-30 22:57:48]

We should probably add a Visitor1 with an argument to js_ast (like we do for
tree nodes).

[Siggi Cherem (dart-lang), 2017-06-30 23:04:34]

I forgot to say lgtm though, just would be nice to go straight to the final
location for this code if it is intended to outlive our migration process.

[Johnni Winther, 2017-07-03 07:54:39]

On 2017/06/30 22:57:48, sra1 wrote:
> We should probably add a Visitor1 with an argument to js_ast (like we do for
> tree nodes).

Yes. I'll do that.

[Johnni Winther, 2017-07-03 07:55:38]

On 2017/06/30 22:24:01, Siggi Cherem (dart-lang) wrote:
> should the equivalence checks for js-asts should move into
> package:js_ast/testing?
> 
Maybe.

[Johnni Winther, 2017-07-03 08:00:37]

Description was changed from

==========
Add equivalence testing on JS nodes to support different label names
==========

to

==========
Add equivalence testing on JS nodes to support different label names

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3433c71c2ead38a994b39fe254933669995c5b4d
==========

[Johnni Winther, 2017-07-03 08:00:38]

Committed patchset #1 (id:1) manually as
3433c71c2ead38a994b39fe254933669995c5b4d (presubmit successful).

[Johnni Winther, 2017-07-03 08:01:02]

https://codereview.chromium.org/2963193003/diff/1/tests/compiler/dart2js/kern...
File tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart (left):

https://codereview.chromium.org/2963193003/diff/1/tests/compiler/dart2js/kern...
tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart:92: //if (i ==
5) continue;
On 2017/06/30 22:24:01, Siggi Cherem (dart-lang) wrote:
> did you mean to keep the `if (i == 5) continue;` statement?

No. It requires labels which is why it is move the the next test.