Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 2963173002: Pass target elements being renamed into validator. (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -33 lines) Patch
M pkg/analysis_server/lib/src/services/refactoring/rename.dart View 1 chunk +0 lines, -19 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_local.dart View 5 chunks +27 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 5 months ago (2017-06-29 20:23:26 UTC) #1
Brian Wilkerson
lgtm
3 years, 5 months ago (2017-06-29 20:32:14 UTC) #2
scheglov
3 years, 5 months ago (2017-06-29 20:42:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f6b7fd307a8e559f7cf34227b8ced57e3d7c7171 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698