Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 296313003: Revert of Add compressed texture capabilities for GPU devices (Closed)

Created:
6 years, 7 months ago by krajcevski
Modified:
6 years, 7 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Add compressed texture capabilities for GPU devices (https://codereview.chromium.org/292323003/) Reason for revert: Signeness comparison breaks build. After working some more, I think the API design will be cleaner without the Uncompressed enum, so I'm removing it and retesting everything. Original issue's description: > Add compressed texture capabilities for GPU devices > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=14880 TBR=bsalomon@google.com,robertphillips@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14883

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -69 lines) Patch
M include/gpu/GrTypes.h View 1 chunk +0 lines, -13 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 3 chunks +0 lines, -16 lines 0 comments Download
M src/gpu/GrDrawTargetCaps.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 2 chunks +0 lines, -31 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
krajcevski
Created Revert of Add compressed texture capabilities for GPU devices
6 years, 7 months ago (2014-05-23 20:17:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/296313003/1
6 years, 7 months ago (2014-05-23 20:17:26 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 20:17:27 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-23 20:17:27 UTC) #4
hal.canary
lgtm
6 years, 7 months ago (2014-05-23 20:39:38 UTC) #5
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 7 months ago (2014-05-23 20:39:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/296313003/1
6 years, 7 months ago (2014-05-23 20:40:20 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 20:40:29 UTC) #8
Message was sent while issue was closed.
Change committed as 14883

Powered by Google App Engine
This is Rietveld 408576698