Issue 296303002: Fixed dictionary merging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 296303002: Fixed dictionary merging. (Closed)

Created:
6 years, 7 months ago by Vitaly Buka (NO REVIEWS)

Modified:
6 years, 7 months ago

Reviewers:
Noam Samuel

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixed dictionary merging. Added api into privet/info response. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272556

Patch Set 1 #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	components/cloud_devices/tools/prototype/prototype.py	View		2 chunks	+5 lines, -1 line	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Noam Samuel

lgtm https://codereview.chromium.org/296303002/diff/1/components/cloud_devices/tools/prototype/prototype.py File components/cloud_devices/tools/prototype/prototype.py (right): https://codereview.chromium.org/296303002/diff/1/components/cloud_devices/tools/prototype/prototype.py#newcode15 components/cloud_devices/tools/prototype/prototype.py:15: sudo pip install ecdsa Maybe wait to add ...

6 years, 7 months ago (2014-05-23 17:04:35 UTC) #2

Vitaly Buka (NO REVIEWS)

The CQ bit was checked by vitalybuka@chromium.org

6 years, 7 months ago (2014-05-23 17:24:22 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/296303002/1

6 years, 7 months ago (2014-05-23 17:26:15 UTC) #5

Message was sent while issue was closed.

Change committed as 272556

Expand Messages | Collapse Messages