Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3139)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/print_preview/print_preview.js

Issue 2962983002: Print Preview: change getPreview to cr.sendWithPromise (Closed)
Patch Set: Re-comment test Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/print_preview/previewarea/preview_area.js ('k') | chrome/browser/ui/webui/print_preview/print_preview_handler.h » ('j') | chrome/test/data/webui/print_preview/print_preview_tests.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/print_preview/print_preview.js
diff --git a/chrome/browser/resources/print_preview/print_preview.js b/chrome/browser/resources/print_preview/print_preview.js
index 741a50e1d1d08eb1df0cd7cd992dc8f4a83254f7..9798776f766b444b042ec828f8f7adcaec5119e6 100644
--- a/chrome/browser/resources/print_preview/print_preview.js
+++ b/chrome/browser/resources/print_preview/print_preview.js
@@ -350,10 +350,6 @@ cr.define('print_preview', function() {
nativeLayerEventTarget,
print_preview.NativeLayer.EventType.CLOUD_PRINT_ENABLE,
this.onCloudPrintEnable_.bind(this));
- this.tracker.add(
- nativeLayerEventTarget,
- print_preview.NativeLayer.EventType.SETTINGS_INVALID,
- this.onSettingsInvalid_.bind(this));
this.tracker.add(
nativeLayerEventTarget,
print_preview.NativeLayer.EventType.PRINT_PRESET_OPTIONS,
@@ -394,6 +390,10 @@ cr.define('print_preview', function() {
this.previewArea_,
print_preview.PreviewArea.EventType.OPEN_SYSTEM_DIALOG_CLICK,
this.openSystemPrintDialog_.bind(this));
+ this.tracker.add(
+ this.previewArea_,
+ print_preview.PreviewArea.EventType.SETTINGS_INVALID,
+ this.onSettingsInvalid_.bind(this));
this.tracker.add(
this.destinationStore_,
« no previous file with comments | « chrome/browser/resources/print_preview/previewarea/preview_area.js ('k') | chrome/browser/ui/webui/print_preview/print_preview_handler.h » ('j') | chrome/test/data/webui/print_preview/print_preview_tests.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698