Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_ui.cc

Issue 2962983002: Print Preview: change getPreview to cr.sendWithPromise (Closed)
Patch Set: Fix check Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/print_preview/print_preview_ui.cc
diff --git a/chrome/browser/ui/webui/print_preview/print_preview_ui.cc b/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
index 830867348cac1bc11660166acbae791d8ea8786a..74220ae3d0da2e1ea2d6562a3a9de3cb81d7bdd0 100644
--- a/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
+++ b/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
@@ -542,6 +542,10 @@ void PrintPreviewUI::OnInitiatorClosed() {
OnClosePrintPreviewDialog();
}
+void PrintPreviewUI::OnPrintPreviewCancelled() {
+ handler_->OnPrintPreviewCancelled();
+}
+
void PrintPreviewUI::OnPrintPreviewRequest(int request_id) {
if (!initial_preview_start_time_.is_null()) {
UMA_HISTOGRAM_TIMES("PrintPreview.InitializationTime",
@@ -619,10 +623,7 @@ void PrintPreviewUI::OnPreviewDataIsAvailable(int expected_pages_count,
handler_->regenerate_preview_request_count());
initial_preview_start_time_ = base::TimeTicks();
}
- base::Value ui_identifier(id_);
- base::Value ui_preview_request_id(preview_request_id);
- web_ui()->CallJavascriptFunctionUnsafe("updatePrintPreview", ui_identifier,
- ui_preview_request_id);
+ handler_->OnPrintPreviewReady(id_, preview_request_id);
}
void PrintPreviewUI::OnCancelPendingPreviewRequest() {
@@ -631,11 +632,10 @@ void PrintPreviewUI::OnCancelPendingPreviewRequest() {
void PrintPreviewUI::OnPrintPreviewFailed() {
handler_->OnPrintPreviewFailed();
- web_ui()->CallJavascriptFunctionUnsafe("printPreviewFailed");
}
void PrintPreviewUI::OnInvalidPrinterSettings() {
- web_ui()->CallJavascriptFunctionUnsafe("invalidPrinterSettings");
+ handler_->OnInvalidPrinterSettings();
}
void PrintPreviewUI::OnHidePreviewDialog() {
« no previous file with comments | « chrome/browser/ui/webui/print_preview/print_preview_ui.h ('k') | chrome/test/data/webui/print_preview/native_layer_stub.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698