Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/printing/common/print_messages.h

Issue 2962983002: Print Preview: change getPreview to cr.sendWithPromise (Closed)
Patch Set: Fix tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/test/data/webui/print_preview/print_preview_tests.js ('K') | « chrome/test/data/webui/print_preview/print_preview_tests.js ('k') | components/printing/renderer/print_web_view_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/printing/common/print_messages.h
diff --git a/components/printing/common/print_messages.h b/components/printing/common/print_messages.h
index 32b0451b60dd100d57ec67a31a94673f2ebd5359..deeb33e34e93ff29b6181f8684dace5b3b77381d 100644
--- a/components/printing/common/print_messages.h
+++ b/components/printing/common/print_messages.h
@@ -448,8 +448,9 @@ IPC_MESSAGE_ROUTED1(PrintHostMsg_PrintingFailed,
#if BUILDFLAG(ENABLE_PRINT_PREVIEW)
// Tell the browser print preview failed.
-IPC_MESSAGE_ROUTED1(PrintHostMsg_PrintPreviewFailed,
- int /* document cookie */)
+IPC_MESSAGE_ROUTED2(PrintHostMsg_PrintPreviewFailed,
+ int /* document cookie */,
+ int /* request id */)
// Tell the browser print preview was cancelled.
IPC_MESSAGE_ROUTED1(PrintHostMsg_PrintPreviewCancelled,
@@ -458,8 +459,9 @@ IPC_MESSAGE_ROUTED1(PrintHostMsg_PrintPreviewCancelled,
// Tell the browser print preview found the selected printer has invalid
// settings (which typically caused by disconnected network printer or printer
// driver is bogus).
-IPC_MESSAGE_ROUTED1(PrintHostMsg_PrintPreviewInvalidPrinterSettings,
- int /* document cookie */)
+IPC_MESSAGE_ROUTED2(PrintHostMsg_PrintPreviewInvalidPrinterSettings,
+ int /* document cookie */,
+ int /* request id */)
// Run a nested run loop in the renderer until print preview for
// window.print() finishes.
« chrome/test/data/webui/print_preview/print_preview_tests.js ('K') | « chrome/test/data/webui/print_preview/print_preview_tests.js ('k') | components/printing/renderer/print_web_view_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698