Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9331)

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_ui.cc

Issue 2962983002: Print Preview: change getPreview to cr.sendWithPromise (Closed)
Patch Set: Fix tests Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/print_preview/print_preview_ui.cc
diff --git a/chrome/browser/ui/webui/print_preview/print_preview_ui.cc b/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
index 830867348cac1bc11660166acbae791d8ea8786a..a221911f9e59564265611aeae152d239c3ebc704 100644
--- a/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
+++ b/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
@@ -619,23 +619,19 @@ void PrintPreviewUI::OnPreviewDataIsAvailable(int expected_pages_count,
handler_->regenerate_preview_request_count());
initial_preview_start_time_ = base::TimeTicks();
}
- base::Value ui_identifier(id_);
- base::Value ui_preview_request_id(preview_request_id);
- web_ui()->CallJavascriptFunctionUnsafe("updatePrintPreview", ui_identifier,
- ui_preview_request_id);
+ handler_->OnPrintPreviewReady(id_, preview_request_id);
}
void PrintPreviewUI::OnCancelPendingPreviewRequest() {
g_print_preview_request_id_map.Get().Set(id_, -1);
}
-void PrintPreviewUI::OnPrintPreviewFailed() {
- handler_->OnPrintPreviewFailed();
- web_ui()->CallJavascriptFunctionUnsafe("printPreviewFailed");
+void PrintPreviewUI::OnPrintPreviewFailed(int request_id) {
+ handler_->OnPrintPreviewFailed(request_id);
}
-void PrintPreviewUI::OnInvalidPrinterSettings() {
- web_ui()->CallJavascriptFunctionUnsafe("invalidPrinterSettings");
+void PrintPreviewUI::OnInvalidPrinterSettings(int request_id) {
+ handler_->OnInvalidPrinterSettings(request_id);
}
void PrintPreviewUI::OnHidePreviewDialog() {

Powered by Google App Engine
This is Rietveld 408576698