Print Preview: change getPreview to cr.sendWithPromise

chrome/browser/resources/print_preview/print_preview.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(rltoscano): Move data/* into print_preview.data namespace
 
 // <include src="component.js">
 // <include src="print_preview_focus_manager.js">
 //
 
@@ skipping 332 matching lines @@
       this.listenerTracker.add(
           'use-cloud-print', this.onCloudPrintEnable_.bind(this));
     },
 
     /** @override */
     enterDocument: function() {
       // Native layer events.
       var nativeLayerEventTarget = this.nativeLayer_.getEventTarget();
       this.tracker.add(
           nativeLayerEventTarget,
-          print_preview.NativeLayer.EventType.SETTINGS_INVALID,
-          this.onSettingsInvalid_.bind(this));
-      this.tracker.add(
-          nativeLayerEventTarget,
           print_preview.NativeLayer.EventType.PRINT_PRESET_OPTIONS,
           this.onPrintPresetOptionsFromDocument_.bind(this));
       this.tracker.add(
           nativeLayerEventTarget,
           print_preview.NativeLayer.EventType.PAGE_COUNT_READY,
           this.onPageCountReady_.bind(this));
       this.tracker.add(
           nativeLayerEventTarget,
           print_preview.NativeLayer.EventType.MANIPULATE_SETTINGS_FOR_TEST,
           this.onManipulateSettingsForTest_.bind(this));
@@ skipping 18 matching lines @@
           print_preview.PreviewArea.EventType.PREVIEW_GENERATION_DONE,
           this.onPreviewGenerationDone_.bind(this));
       this.tracker.add(
           this.previewArea_,
           print_preview.PreviewArea.EventType.PREVIEW_GENERATION_FAIL,
           this.onPreviewGenerationFail_.bind(this));
       this.tracker.add(
           this.previewArea_,
           print_preview.PreviewArea.EventType.OPEN_SYSTEM_DIALOG_CLICK,
           this.openSystemPrintDialog_.bind(this));
+      this.tracker.add(
+          this.previewArea_,
+          print_preview.PreviewArea.EventType.SETTINGS_INVALID,
+          this.onSettingsInvalid_.bind(this));
 
       this.tracker.add(
           this.destinationStore_,
           print_preview.DestinationStore.EventType
               .SELECTED_DESTINATION_CAPABILITIES_READY,
           this.printIfReady_.bind(this));
       this.tracker.add(
           this.destinationStore_,
           print_preview.DestinationStore.EventType.DESTINATION_SELECT,
           this.onDestinationSelect_.bind(this));
@@ skipping 543 matching lines @@
     },
 
     /**
      * Called when native layer receives invalid settings for a print request.
      * @private
      */
     onSettingsInvalid_: function() {
       this.uiState_ = PrintPreviewUiState_.ERROR;
       this.isPreviewGenerationInProgress_ = false;
       this.printHeader_.isPrintButtonEnabled = false;
       this.previewArea_.cancelTimeout();

[dpapad, 2017/06/30 18:58:39]

This line and the next are now already happening within previewArea_ itself,
before the SETTINGS_INVALID is fired. Can we remove them from here? 

[rbpotter, 2017/06/30 19:45:22]

Done.

       this.previewArea_.showCustomMessage(
           loadTimeData.getString('invalidPrinterSettings'));
     },
 
     /**
      * Called when the destination settings' change button is activated.
      * Displays the destination search component.
      * @private
      */
     onDestinationChangeButtonActivate_: function() {
@@ skipping 394 matching lines @@
 // <include src="search/destination_search.js">
 // <include src="search/provisional_destination_resolver.js">
 
 window.addEventListener('DOMContentLoaded', function() {
   var previewWindow = /** @type {{isTest: boolean}} */ (window);
   if (!previewWindow.isTest) {
     var printPreview = new print_preview.PrintPreview();
     printPreview.initialize();
   }
 });