Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: net/quic/core/quic_session_test.cc

Issue 2962953002: In QUIC, do not enable forced HOL blocking if FLAGS_quic_reloadable_flag_quic_use_stream_notifier2 … (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/core/quic_spdy_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_session_test.cc
diff --git a/net/quic/core/quic_session_test.cc b/net/quic/core/quic_session_test.cc
index 8877be83158c32b399ec89184ebe847b68d4b791..9d0b86fff7434e654f8b691f87b33c92777f04b6 100644
--- a/net/quic/core/quic_session_test.cc
+++ b/net/quic/core/quic_session_test.cc
@@ -1256,7 +1256,7 @@ TEST_P(QuicSessionTestServer, TestMaxIncomingAndOutgoingStreamsAllowed) {
TEST_P(QuicSessionTestServer, EnableFHOLThroughConfigOption) {
QuicConfigPeer::SetReceivedForceHolBlocking(session_.config());
session_.OnConfigNegotiated();
- if (version() != QUIC_VERSION_36) {
+ if (version() != QUIC_VERSION_36 || session_.use_stream_notifier()) {
EXPECT_FALSE(session_.force_hol_blocking());
} else {
EXPECT_TRUE(session_.force_hol_blocking());
@@ -1341,7 +1341,7 @@ TEST_P(QuicSessionTestClient, EnableDHDTThroughConnectionOption) {
TEST_P(QuicSessionTestClient, EnableFHOLThroughConfigOption) {
session_.config()->SetForceHolBlocking();
session_.OnConfigNegotiated();
- if (version() != QUIC_VERSION_36) {
+ if (version() != QUIC_VERSION_36 || session_.use_stream_notifier()) {
EXPECT_FALSE(session_.force_hol_blocking());
} else {
EXPECT_TRUE(session_.force_hol_blocking());
« no previous file with comments | « no previous file | net/quic/core/quic_spdy_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698