Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 296293002: Log InitializeICU() failures in relase build (Closed)

Created:
6 years, 7 months ago by Xianzhu
Modified:
6 years, 7 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org, Feng Qian
Visibility:
Public.

Description

Log InitializeICU() failures in relase build Initialize failure causes immediate renderer crash. The logs about the failures are useful for debugging the reason in the environemnt that can reproduce the failure. BUG=374362, 376072 R=jshin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272986

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M base/i18n/icu_util.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Xianzhu
6 years, 7 months ago (2014-05-23 16:48:58 UTC) #1
jungshik at Google
LGTM Yup, I found it extremely useful during my ICU update test on various platforms ...
6 years, 7 months ago (2014-05-24 00:17:07 UTC) #2
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 7 months ago (2014-05-25 00:56:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/296293002/1
6 years, 7 months ago (2014-05-25 00:56:38 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-25 03:49:09 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-25 03:52:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/77450)
6 years, 7 months ago (2014-05-25 03:52:29 UTC) #7
Xianzhu
The CQ bit was checked by wangxianzhu@chromium.org
6 years, 7 months ago (2014-05-27 16:14:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/296293002/1
6 years, 7 months ago (2014-05-27 16:15:41 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 7 months ago (2014-05-27 16:22:01 UTC) #10
Xianzhu
6 years, 7 months ago (2014-05-27 16:35:02 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 manually as r272986 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698