Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2962913002: Create an option to disable type inference and type promotion. (Closed)

Created:
3 years, 5 months ago by Paul Berry
Modified:
3 years, 5 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Create an option to disable type inference and type promotion. This is intended for profiling, to ensure that type inference and type promotion do not slow down compilation too much. Currently the option is just plumbed through to the kernel Target class since I'm not exactly sure how we'll want to enable/disable this option; we can plumb it the rest of the way in a future CL. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/7ee5d4b3a27e422ce714300aaaed1cafc029809f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -5 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_listener.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 2 chunks +6 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 1 chunk +29 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_promotion.dart View 1 chunk +38 lines, -0 lines 0 comments Download
M pkg/kernel/lib/target/targets.dart View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 5 months ago (2017-06-28 17:51:03 UTC) #2
ahe
lgtm
3 years, 5 months ago (2017-06-29 10:20:16 UTC) #3
Paul Berry
3 years, 5 months ago (2017-06-29 12:31:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7ee5d4b3a27e422ce714300aaaed1cafc029809f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698