Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1691)

Unified Diff: chrome/browser/resources/settings/settings_ui/settings_ui.js

Issue 2962823002: MD Settings: decouple page visibility from settings_ui.html. (Closed)
Patch Set: moving import out of this CL Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_ui/settings_ui.js
diff --git a/chrome/browser/resources/settings/settings_ui/settings_ui.js b/chrome/browser/resources/settings/settings_ui/settings_ui.js
index 279ebc7b915446371f358859231240db40e2136c..cc6620b5d8fb9654c43210ddfc6bc458c9369486 100644
--- a/chrome/browser/resources/settings/settings_ui/settings_ui.js
+++ b/chrome/browser/resources/settings/settings_ui/settings_ui.js
@@ -49,12 +49,9 @@ Polymer({
},
/**
- * Dictionary defining page visibility.
- * This is only set when in guest mode. All pages are visible when not set
- * because polymer only notifies after a property is set.
* @private {!GuestModePageVisibility}
*/
- pageVisibility_: Object,
+ pageVisibility_: {type: Object, value: settings.pageVisibility},
/** @private */
showAndroidApps_: Boolean,
@@ -126,37 +123,6 @@ Polymer({
};
// </if>
- if (loadTimeData.getBoolean('isGuest')) {
- this.pageVisibility_ = {
- passwordsAndForms: false,
- people: false,
- onStartup: false,
- reset: false,
- // <if expr="not chromeos">
- appearance: false,
- defaultBrowser: false,
- advancedSettings: false,
- // </if>
- // <if expr="chromeos">
- appearance: {
- setWallpaper: false,
- setTheme: false,
- homeButton: false,
- bookmarksBar: false,
- pageZoom: false,
- },
- advancedSettings: true,
- privacy: {
- searchPrediction: false,
- networkPrediction: false,
- },
- downloads: {
- googleDrive: false,
- },
- // </if>
- };
- }
-
this.showAndroidApps_ = loadTimeData.valueExists('androidAppsVisible') &&
loadTimeData.getBoolean('androidAppsVisible');

Powered by Google App Engine
This is Rietveld 408576698