MD Settings: decouple page visibility from settings_ui.html.

chrome/browser/resources/settings/settings_ui/settings_ui.js

Index: chrome/browser/resources/settings/settings_ui/settings_ui.js
diff --git a/chrome/browser/resources/settings/settings_ui/settings_ui.js b/chrome/browser/resources/settings/settings_ui/settings_ui.js
index 279ebc7b915446371f358859231240db40e2136c..486cd28d93414943d2947e84abb6d72334895bdf 100644
--- a/chrome/browser/resources/settings/settings_ui/settings_ui.js
+++ b/chrome/browser/resources/settings/settings_ui/settings_ui.js
@@ -54,7 +54,12 @@ Polymer({
      * because polymer only notifies after a property is set.
      * @private {!GuestModePageVisibility}
      */
-    pageVisibility_: Object,
+    pageVisibility_: {
+      type: Object,
+      value: function() {

[dpapad, 2017/06/28 01:16:11]

Is the function() wrapper necessary? Can this be simply

value: settings.PageVisibility,

[scottchen, 2017/06/28 20:51:49]

Done.

+        return settings.PageVisibility;
+      }
+    },
 
     /** @private */
     showAndroidApps_: Boolean,
@@ -126,37 +131,6 @@ Polymer({
     };
     // </if>
 
-    if (loadTimeData.getBoolean('isGuest')) {
-      this.pageVisibility_ = {
-        passwordsAndForms: false,
-        people: false,
-        onStartup: false,
-        reset: false,
-        // <if expr="not chromeos">
-        appearance: false,
-        defaultBrowser: false,
-        advancedSettings: false,
-        // </if>
-        // <if expr="chromeos">
-        appearance: {
-          setWallpaper: false,
-          setTheme: false,
-          homeButton: false,
-          bookmarksBar: false,
-          pageZoom: false,
-        },
-        advancedSettings: true,
-        privacy: {
-          searchPrediction: false,
-          networkPrediction: false,
-        },
-        downloads: {
-          googleDrive: false,
-        },
-        // </if>
-      };
-    }
-
     this.showAndroidApps_ = loadTimeData.valueExists('androidAppsVisible') &&
         loadTimeData.getBoolean('androidAppsVisible');