chrome/browser/resources/settings/route.html - Issue 2962823002: MD Settings: decouple page visibility from settings_ui.html.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/route.html

Issue 2962823002: MD Settings: decouple page visibility from settings_ui.html. (Closed)

Patch Set: closure compiler Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <link rel="import" href="chrome://resources/html/cr.html">	1 <link rel="import" href="chrome://resources/html/cr.html">

2 <link rel="import" href="i18n_setup.html">	2 <link rel="import" href="i18n_setup.html">

	3 <link rel="import" href="page_visibility.html">
	dpapad 2017/06/28 21:48:41 This should be in the next CL, since route.js is n This should be in the next CL, since route.js is not referring to pageVisibility yet. scottchen 2017/06/29 18:57:21 Acknowledged. Show quoted text On 2017/06/28 21:48:41, dpapad wrote: > This should be in the next CL, since route.js is not referring to pageVisibility > yet. Acknowledged.
3	4

4 <script src="route.js"></script>	5 <script src="route.js"></script>

OLD	NEW