MD Settings: decouple page visibility from settings_ui.html.

chrome/browser/resources/settings/settings_ui/settings_ui.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-ui' implements the UI for the Settings page.
  *
  * Example:
  *
@@ skipping 36 matching lines @@
       type: Boolean,
       value: false,
     },
 
     /**
      * Dictionary defining page visibility.
      * This is only set when in guest mode. All pages are visible when not set
      * because polymer only notifies after a property is set.
      * @private {!GuestModePageVisibility}
      */
-    pageVisibility_: Object,
+    pageVisibility_: {
+      type: Object,
+      value: function() {

[dpapad, 2017/06/28 01:16:11]

Is the function() wrapper necessary? Can this be simply

value: settings.PageVisibility,

[scottchen, 2017/06/28 20:51:49]

Done.

+        return settings.PageVisibility;
+      }
+    },
 
     /** @private */
     showAndroidApps_: Boolean,
 
     /** @private */
     lastSearchQuery_: {
       type: String,
       value: '',
     }
   },
@@ skipping 51 matching lines @@
       networkListItemConnecting:
           loadTimeData.getString('networkListItemConnecting'),
       networkListItemConnectingTo:
           loadTimeData.getString('networkListItemConnectingTo'),
       networkListItemNotConnected:
           loadTimeData.getString('networkListItemNotConnected'),
       vpnNameTemplate: loadTimeData.getString('vpnNameTemplate'),
     };
     // </if>
 
-    if (loadTimeData.getBoolean('isGuest')) {
-      this.pageVisibility_ = {
-        passwordsAndForms: false,
-        people: false,
-        onStartup: false,
-        reset: false,
-        // <if expr="not chromeos">
-        appearance: false,
-        defaultBrowser: false,
-        advancedSettings: false,
-        // </if>
-        // <if expr="chromeos">
-        appearance: {
-          setWallpaper: false,
-          setTheme: false,
-          homeButton: false,
-          bookmarksBar: false,
-          pageZoom: false,
-        },
-        advancedSettings: true,
-        privacy: {
-          searchPrediction: false,
-          networkPrediction: false,
-        },
-        downloads: {
-          googleDrive: false,
-        },
-        // </if>
-      };
-    }
-
     this.showAndroidApps_ = loadTimeData.valueExists('androidAppsVisible') &&
         loadTimeData.getBoolean('androidAppsVisible');
 
     this.addEventListener('show-container', function() {
       this.$.container.style.visibility = 'visible';
     }.bind(this));
 
     this.addEventListener('hide-container', function() {
       this.$.container.style.visibility = 'hidden';
     }.bind(this));
@@ skipping 116 matching lines @@
     listenOnce(this.$.container, ['blur', 'pointerdown'], function() {
       this.$.container.removeAttribute('tabindex');
     }.bind(this));
   },
 
   /** @private */
   directionDelegateChanged_: function() {
     this.$.drawer.align = this.directionDelegate.isRtl() ? 'right' : 'left';
   },
 });