MD Settings: decouple page visibility from settings_ui.html.

chrome/browser/resources/settings/page_visibility.js

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+cr.define('settings', function() {

[dpapad, 2017/06/28 01:16:11]

Can you add a compile target for this file?

[scottchen, 2017/06/28 20:51:49]

Done.

+
+  var PageVisibility = {};
+
+  if (loadTimeData.getBoolean('isGuest')) {
+    PageVisibility = Object.assign(PageVisibility, {

[dpapad, 2017/06/28 01:16:11]

Is the call to Object.assign necessary here? Isn't PageVisibility always empty
at this point?

[scottchen, 2017/06/28 20:51:49]

Acknowledged.

+      passwordsAndForms: false,
+      people: false,
+      onStartup: false,
+      reset: false,
+      // <if expr="not chromeos">
+      appearance: false,
+      defaultBrowser: false,
+      advancedSettings: false,
+      // </if>
+      // <if expr="chromeos">
+      appearance: {
+        setWallpaper: false,
+        setTheme: false,
+        homeButton: false,
+        bookmarksBar: false,
+        pageZoom: false,
+      },
+      advancedSettings: true,
+      privacy: {
+        searchPrediction: false,
+        networkPrediction: false,
+      },
+      downloads: {
+        googleDrive: false,
+      },
+      // </if>
+    });
+  }
+
+  return {PageVisibility: PageVisibility};

[dpapad, 2017/06/28 01:16:11]

Nit: Usually upper case is used to name a class, not an instance of a class.
Should this be
{pageVisibility: pageVisibility} instead?

[scottchen, 2017/06/28 20:51:49]

Done.

+});