Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2343)

Unified Diff: chrome/browser/resource_coordinator/tab_manager_web_contents_data.h

Issue 2962773002: [Tab Metrics] Added TabManager.SessionRestore.SwitchToTab UMA. (Closed)
Patch Set: Fix comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resource_coordinator/tab_manager_web_contents_data.h
diff --git a/chrome/browser/resource_coordinator/tab_manager_web_contents_data.h b/chrome/browser/resource_coordinator/tab_manager_web_contents_data.h
index b77e5cb8388a915c2097feaa31c4099f0cd876ac..6f1f2e7384db94115b6c22432790928389aa9cca 100644
--- a/chrome/browser/resource_coordinator/tab_manager_web_contents_data.h
+++ b/chrome/browser/resource_coordinator/tab_manager_web_contents_data.h
@@ -29,11 +29,10 @@ namespace resource_coordinator {
// occurs in the main frame, which happens if the user navigates to a new page
// and the WebContents is reused.
//
+// These values are used in the TabManager.SessionRestore.SwitchToTab UMA.
+//
// TODO(shaseley): *switch to the new done signal (network and cpu quiescence)
// when available.
-//
-// TODO(shaseley): This will become an UMA histogram once the TabManager is
-// aware of session restore begin/end and background tab loading begin/end.
enum TabLoadingState {
Mark P 2017/06/29 18:25:51 This needs the standard warning about changing val
shaseley 2017/06/29 19:45:16 Done.
TAB_IS_NOT_LOADING = 0,
TAB_IS_LOADING = 1,
@@ -129,6 +128,7 @@ class TabManager::WebContentsData
// Needed to access tab_data_.
FRIEND_TEST_ALL_PREFIXES(TabManagerWebContentsDataTest, CopyState);
FRIEND_TEST_ALL_PREFIXES(TabManagerWebContentsDataTest, TabLoadingState);
+ FRIEND_TEST_ALL_PREFIXES(TabManagerTest, HistogramsSessionRestoreSwitchToTab);
struct Data {
Data();

Powered by Google App Engine
This is Rietveld 408576698