Chromium Code Reviews| Index: chrome/browser/resource_coordinator/tab_manager_web_contents_data.h |
| diff --git a/chrome/browser/resource_coordinator/tab_manager_web_contents_data.h b/chrome/browser/resource_coordinator/tab_manager_web_contents_data.h |
| index b77e5cb8388a915c2097feaa31c4099f0cd876ac..2d376a456010eb6fa9b7a0e8c4b45347046b4e93 100644 |
| --- a/chrome/browser/resource_coordinator/tab_manager_web_contents_data.h |
| +++ b/chrome/browser/resource_coordinator/tab_manager_web_contents_data.h |
| @@ -29,11 +29,13 @@ namespace resource_coordinator { |
| // occurs in the main frame, which happens if the user navigates to a new page |
| // and the WebContents is reused. |
| // |
| +// These values are used in the TabManager.SessionRestore.SwitchToTab UMA. |
| +// |
| +// TODO(shaseley): Add a reference to the new metric when background tab loading |
| +// is done. |
| +// |
| // TODO(shaseley): *switch to the new done signal (network and cpu quiescence) |
| // when available. |
| -// |
| -// TODO(shaseley): This will become an UMA histogram once the TabManager is |
| -// aware of session restore begin/end and background tab loading begin/end. |
| enum TabLoadingState { |
| TAB_IS_NOT_LOADING = 0, |
|
lpy
2017/06/27 22:30:36
I think that TAB_IS_NOT_LOADING is not accurate, a
shaseley
2017/06/27 23:22:10
I know what you mean, the names are a little confu
|
| TAB_IS_LOADING = 1, |
| @@ -129,6 +131,7 @@ class TabManager::WebContentsData |
| // Needed to access tab_data_. |
| FRIEND_TEST_ALL_PREFIXES(TabManagerWebContentsDataTest, CopyState); |
| FRIEND_TEST_ALL_PREFIXES(TabManagerWebContentsDataTest, TabLoadingState); |
| + FRIEND_TEST_ALL_PREFIXES(TabManagerTest, HistogramsSessionRestoreSwitchToTab); |
| struct Data { |
| Data(); |