Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 296273002: Really fix building android webview on mac. (Closed)

Created:
6 years, 7 months ago by Torne
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Really fix building android webview on mac. The refactoring in the final patchset landed as r269766 got the condition backwards (the pre-refactoring version worked), so we were accidentally excluding flag only on *target* builds, instead of host builds as intended (the target compiler supports this flag). Fix it. BUG=321833 R=primiano@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272511

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Torne
This is a fix for https://codereview.chromium.org/277983002/ which I screwed up between PS1 and PS2. :)
6 years, 7 months ago (2014-05-23 09:35:53 UTC) #1
Primiano Tucci (use gerrit)
lgtm
6 years, 7 months ago (2014-05-23 09:48:17 UTC) #2
Torne
The CQ bit was checked by torne@chromium.org
6 years, 7 months ago (2014-05-23 09:50:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/296273002/1
6 years, 7 months ago (2014-05-23 09:52:33 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 13:30:46 UTC) #5
Torne
6 years, 7 months ago (2014-05-23 13:35:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r272511 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698