Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4399)

Unified Diff: appengine/config_service/ui/src/config-ui/config-ui.html

Issue 2962703003: config_service: Add authentication to the UI. (Closed)
Patch Set: Added the modified file. Changes can be seen by clicking on Delta from patch set 2. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/config_service/ui/src/config-ui/config-ui.html
diff --git a/appengine/config_service/ui/src/config-ui/config-ui.html b/appengine/config_service/ui/src/config-ui/config-ui.html
index fd09d9199373a94c3115bc35673a07f9d775a224..2d0c5cbdaf51dedf0bbe84d5c8e6c4d6731d28e4 100644
--- a/appengine/config_service/ui/src/config-ui/config-ui.html
+++ b/appengine/config_service/ui/src/config-ui/config-ui.html
@@ -10,12 +10,17 @@
<link rel="import" href="../../bower_components/app-route/app-location.html">
<link rel="import" href="../../bower_components/app-route/app-route.html">
+<link rel="import" href="../../common/auth-signin.html">
<link rel="import" href="config-set.html">
<link rel="import" href="front-page.html">
<dom-module id="config-ui">
<template>
<style>
+ * {
+ font-family: sans-serif;
+ }
+
app-toolbar {
background-color: #efefef;
color: #232323;
@@ -29,11 +34,14 @@
height: 100%;
}
+ .right {
+ margin-left:15px;
+ }
+
.title {
padding-left: 1%;
padding-bottom: 0.5%;
font-size: 150%;
- font-family: sans-serif;
}
</style>
@@ -43,41 +51,59 @@
<div class="title" main-title>
Configuration Service (not fully implemented)
</div>
+
+ <template is="dom-if" if="[[client_id]]">
+ <auth-signin
+ class="right"
+ client_id="[[client_id]]"
+ auth_headers="{{auth_headers}}"
+ profile="{{profile}}"
+ signed_in="{{signed_in}}">
+ </auth-signin>
+ </template>
+ <template is="dom-if" if="[[!client_id]]">
+ <div class="right">No OAauth client id found.</div>
+ </template>
</app-toolbar>
</app-header>
<app-location route="{{route}}" use-hash-as-path></app-location>
- <app-route route="{{route}}"
- pattern="/services/:serviceName"
- data="{{serviceData}}"
- tail="{{serviceTail}}"
+ <app-route route="{{route}}"
+ pattern="/services/:serviceName"
+ data="{{serviceData}}"
+ tail="{{serviceTail}}"
active="{{serviceActive}}"></app-route>
<app-route route="{{route}}"
pattern="/projects/:projectName"
data="{{projectData}}"
tail="{{projectTail}}"
- active="{{projectActive}}"></app-route>-->
+ active="{{projectActive}}"></app-route>
<app-route route="{{route}}"
pattern="/"
active="{{frontPageActive}}"></app-route>
<div hidden$="[[!frontPageActive]]">
Sergey Berezin 2017/06/28 19:53:02 nit: would it also work if we wrap the subpages in
cwpayton 2017/06/29 22:28:15 This sounds like it would work a bit better for wh
- <front-page></front-page>
+ <front-page auth_headers="{{auth_headers}}"
+ hidden="[[!frontPageActive]]"></front-page>
</div>
<div hidden$="[[!serviceActive]]">
<config-set category="services"
name="{{serviceData.serviceName}}"
- route="{{serviceTail}}"></config-set>
+ route="{{serviceTail}}"
+ auth_headers="{{auth_headers}}"
+ hidden="[[!serviceActive]]"></config-set>
</div>
<div hidden$="[[!projectActive]]">
<config-set category="projects"
name="{{projectData.projectName}}"
- route="{{projectTail}}"></config-set>
+ route="{{projectTail}}"
+ auth_headers="{{auth_headers}}"
+ hidden="[[!projectActive]]"></config-set>
</div>
</template>
@@ -85,6 +111,23 @@
<script>
Polymer({
is: 'config-ui',
+
+ properties: {
+ auth_headers: {
+ type: Object,
+ notify: true
+ },
+
+ client_id: {
+ type: String,
+ value: null
+ },
+
+ profile: {
+ type: Object,
+ notify: true
+ }
+ },
ready: function() {
this.async(function() {

Powered by Google App Engine
This is Rietveld 408576698