Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1697)

Unified Diff: appengine/config_service/ui/common/third_party/google-signin/google-signin-aware.html

Issue 2962703003: config_service: Add authentication to the UI. (Closed)
Patch Set: Added TODO to handlers.py and confirmed versions in bower.json Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/config_service/ui/common/third_party/google-signin/google-signin-aware.html
diff --git a/appengine/config_service/ui/common/third-party/google-signin-aware.html b/appengine/config_service/ui/common/third_party/google-signin/google-signin-aware.html
similarity index 97%
rename from appengine/config_service/ui/common/third-party/google-signin-aware.html
rename to appengine/config_service/ui/common/third_party/google-signin/google-signin-aware.html
index e6e731bfad1a7417e19f977e4944c011a4a2f6bd..4368b2951ff1de04b15fd5ca85c604ff5b85e284 100644
--- a/appengine/config_service/ui/common/third-party/google-signin-aware.html
+++ b/appengine/config_service/ui/common/third_party/google-signin/google-signin-aware.html
@@ -14,8 +14,8 @@ See the License for the specific language governing permissions and
limitations under the License.
-->
-<link rel="import" href="../polymer/polymer.html">
-<link rel="import" href="../google-apis/google-js-api.html">
+<link rel="import" href="../../../bower_components/polymer/polymer.html">
+<link rel="import" href="../../../bower_components/google-apis/google-js-api.html">
<script>
(function() {
@@ -230,15 +230,19 @@ limitations under the License.
signinAwares: [],
init: function() {
- this._apiLoader = document.createElement('google-js-api');
- this._apiLoader.addEventListener('js-api-load', this.loadAuth2.bind(this));
- if (Polymer.Element) {
- document.body.appendChild(this._apiLoader);
- }
+ var that = this;
+ document.addEventListener('DOMContentLoaded', function() {
+ that._apiLoader = document.createElement('google-js-api');
+ that._apiLoader.addEventListener('js-api-load', that.loadAuth2.bind(that));
+ if (Polymer.Element) {
+ document.body.appendChild(that._apiLoader);
+ }
+ })
},
loadAuth2: function() {
- gapi.load('auth2', this.initAuth2.bind(this));
+ var that = this;
+ gapi.load('auth2', that.initAuth2.bind(that));
},
initAuth2: function() {

Powered by Google App Engine
This is Rietveld 408576698