appengine/config_service/ui/static/index.html - Issue 2962703003: config_service: Add authentication to the UI.

Side by Side Diff: appengine/config_service/ui/static/index.html

Issue 2962703003: config_service: Add authentication to the UI. (Closed)

Patch Set: Added the modified file. Changes can be seen by clicking on Delta from patch set 2. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!--	1 <!--

2 Copyright 2017 The LUCI Authors. All rights reserved.	2 Copyright 2017 The LUCI Authors. All rights reserved.

3 Use of this source code is governed under the Apache License, Version 2.0	3 Use of this source code is governed under the Apache License, Version 2.0

4 that can be found in the LICENSE file.	4 that can be found in the LICENSE file.

5 -->	5 -->

6	6

7 <!doctype html>	7 <!doctype html>

8 <html lang="en">	8 <html lang="en">

9 <head>	9 <head>

10 <meta charset="utf-8">	10 <meta charset="utf-8">

11 <meta name="viewport" content="width=device-width, minimum-scale=1, initial- scale=1, user-scalable=yes">	11 <meta name="viewport" content="width=device-width, minimum-scale=1, initial- scale=1, user-scalable=yes">

12	12

13 <title>Configuration Service</title>	13 <title>Configuration Service</title>

14 <meta name="description" content="This is a UI for the configuration service ">	14 <meta name="description" content="This is a UI for the configuration service ">

15	15

16 <!-- See https://goo.gl/OOhYW5 -->	16 <!-- See https://goo.gl/OOhYW5 -->

17 <link rel="manifest" href="/manifest.json">	17 <link rel="manifest" href="/manifest.json">

18 <link rel="import" href="../src/config-ui/config-ui.html">	18 <link rel="import" href="../src/config-ui/config-ui.html">

19 <script src="../bower_components/webcomponentsjs/webcomponents-loader.js"></ script>	19 <script src="../bower_components/webcomponentsjs/webcomponents-loader.js"></ script>

20 </head>	20 </head>

21 <body>	21 <body>

22 <config-ui></config-ui>	22 <config-ui

	23 client_id="247108661754-svmo17vmk1j5hlt388gb45qblgvg2h98.apps.googleuserco ntent.com">
	Sergey Berezin 2017/06/28 19:53:02 I'd rather not bake a specific client ID into the I'd rather not bake a specific client ID into the code. One way to supply a client_id is to generate index.html dynamically by the server, where the client_id is injected into the html e.g. through jinja template. Ayana had it setup earlier here: https://codereview.chromium.org/2936423002/diff/60001/appengine/config_servic... but it wasn't necessary at the time. Maybe it's time to revive it. Another way is to add an endpoint to serve client_id and request it after loading the page, but this will slow down overall page load, and may be unnecessary complicated in Polymer. We'd also need to add client_id entry to the config proto: https://github.com/luci/luci-py/blob/master/appengine/components/components/c... and then add the actual value in the specific configs in the internal repo (will follow up offline for those). This is how the server would know its specific client_id without baking it into the code. Proto modifications should be done in a separate CL, and this CL will depend on it. cwpayton 2017/06/29 22:28:15 I fixed this by serving the client_id through a ji Show quoted text On 2017/06/28 19:53:02, Sergey Berezin wrote: > I'd rather not bake a specific client ID into the code. One way to supply a > client_id is to generate index.html dynamically by the server, where the > client_id is injected into the html e.g. through jinja template. > > Ayana had it setup earlier here: > https://codereview.chromium.org/2936423002/diff/60001/appengine/config_servic... > but it wasn't necessary at the time. Maybe it's time to revive it. > > Another way is to add an endpoint to serve client_id and request it after > loading the page, but this will slow down overall page load, and may be > unnecessary complicated in Polymer. > > We'd also need to add client_id entry to the config proto: > https://github.com/luci/luci-py/blob/master/appengine/components/components/c... > and then add the actual value in the specific configs in the internal repo (will > follow up offline for those). This is how the server would know its specific > client_id without baking it into the code. > > Proto modifications should be done in a separate CL, and this CL will depend on > it. I fixed this by serving the client_id through a jinja template for now. We can discuss proto modifications more offline.
	24 </config-ui>

23 </body>	25 </body>

24 </html>	26 </html>

OLD	NEW

« appengine/config_service/ui/src/config-ui/config-ui.html ('K') | « appengine/config_service/ui/src/config-ui/front-page.html ('k') | no next file » | no next file with comments »