Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2962583002: Add type inference for break and continue statements. (Closed)

Created:
3 years, 5 months ago by Paul Berry
Modified:
3 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add type inference for break and continue statements. Note that no actual type inference needs to be performed, but we still need to implement the _inferStatement() methods so that we can get rid of the hack in KernelTypeInferrer.inferStatement. Also, we need to call into the listener so that once this logic is hooked into AstBuilder, analyzer will stay in sync with type inference. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/2f7c6d61f516c1a6df55eba065375854f4723c7c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -3 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 2 chunks +27 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart View 2 chunks +12 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/switch_continue.dart View 1 chunk +23 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/switch_continue.dart.direct.expect View 1 chunk +22 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/switch_continue.dart.outline.expect View 1 chunk +8 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/switch_continue.dart.strong.expect View 1 chunk +22 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/kompile.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 5 months ago (2017-06-26 20:23:33 UTC) #2
scheglov
LGTM
3 years, 5 months ago (2017-06-26 20:30:05 UTC) #3
Paul Berry
3 years, 5 months ago (2017-06-26 21:51:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2f7c6d61f516c1a6df55eba065375854f4723c7c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698