Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1882)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataTabsFragment.java

Issue 2962523003: Improve histogram and actions for CBD dialog (Closed)
Patch Set: Improve histogram summary Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataTabsFragment.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataTabsFragment.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataTabsFragment.java
index 59814cb10ce16da8ca45d7e5c830158f29f5bcde..baa595e9f013b34d88f3bbbf503a1ca96f47f2b0 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataTabsFragment.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataTabsFragment.java
@@ -20,6 +20,7 @@ import android.view.ViewGroup;
import org.chromium.base.metrics.RecordUserAction;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ChromeFeatureList;
+import org.chromium.chrome.browser.browsing_data.ClearBrowsingDataTab;
import org.chromium.chrome.browser.preferences.PrefServiceBridge;
import org.chromium.chrome.browser.preferences.Preferences;
@@ -80,13 +81,13 @@ public class ClearBrowsingDataTabsFragment extends Fragment {
// Give the TabLayout the ViewPager.
TabLayout tabLayout = (TabLayout) view.findViewById(R.id.clear_browsing_data_tabs);
tabLayout.setupWithViewPager(viewPager);
- tabLayout.addOnTabSelectedListener(new TabSelectListener());
int tabIndex = adjustIndexForDirectionality(
PrefServiceBridge.getInstance().getLastSelectedClearBrowsingDataTab());
TabLayout.Tab tab = tabLayout.getTabAt(tabIndex);
if (tab != null) {
tab.select();
}
+ tabLayout.addOnTabSelectedListener(new TabSelectListener());
// Remove elevation to avoid shadow between title and tabs.
Preferences activity = (Preferences) getActivity();
@@ -140,6 +141,11 @@ public class ClearBrowsingDataTabsFragment extends Fragment {
public void onTabSelected(TabLayout.Tab tab) {
int tabIndex = adjustIndexForDirectionality(tab.getPosition());
PrefServiceBridge.getInstance().setLastSelectedClearBrowsingDataTab(tabIndex);
+ if (tabIndex == ClearBrowsingDataTab.BASIC) {
+ RecordUserAction.record("ClearBrowsingData_SwitchTo_BasicTab");
+ } else {
+ RecordUserAction.record("ClearBrowsingData_SwitchTo_AdvancedTab");
+ }
}
@Override

Powered by Google App Engine
This is Rietveld 408576698