third_party/WebKit/Source/core/editing/PositionTest.cpp - Issue 2962473002: Make Position::LastPositionInNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/PositionTest.cpp

Issue 2962473002: Make Position::LastPositionInNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-26T14:00:00 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/PositionTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/PositionTest.cpp b/third_party/WebKit/Source/core/editing/PositionTest.cpp

index 63532a6f426ef678cdec41ed451c8f15e6c8b18b..a7afc6e3b246bc1dc2f3c6f4961a6b0587817c79 100644

--- a/third_party/WebKit/Source/core/editing/PositionTest.cpp

+++ b/third_party/WebKit/Source/core/editing/PositionTest.cpp

@@ -30,11 +30,11 @@ TEST_F(PositionTest, IsEquivalent) {

EXPECT_TRUE(Position(sample, 3).IsEquivalent(

Position::AfterNode(*sample->lastChild())));

EXPECT_TRUE(

- Position(sample, 3).IsEquivalent(Position::LastPositionInNode(sample)));

+ Position(sample, 3).IsEquivalent(Position::LastPositionInNode(*sample)));

EXPECT_FALSE(Position(sample, 0).IsEquivalent(Position(sample, 1)));

EXPECT_FALSE(

- Position(sample, 0).IsEquivalent(Position::LastPositionInNode(sample)));

+ Position(sample, 0).IsEquivalent(Position::LastPositionInNode(*sample)));

}

TEST_F(PositionTest, NodeAsRangeLastNodeNull) {