Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Unified Diff: chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html

Issue 2962413002: Separate manufacturer and model fields from PPD info (Closed)
Patch Set: rebase Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
diff --git a/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html b/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
index b030d519a2540e916d35a886118378d27bf6649b..2c12065200bdc47bda951ec64baba8a77f73ede4 100644
--- a/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
+++ b/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
@@ -298,7 +298,7 @@
<div class="label">$i18n{printerManufacturer}</div>
<div class="secondary">
<drop-down-search-box items="[[manufacturerList]]"
- selected-item="{{newPrinter.printerManufacturer}}">
+ selected-item="{{newPrinter.ppdManufacturer}}">
</drop-down-search-box>
</div>
</div>
@@ -308,7 +308,7 @@
<div class="label">$i18n{printerModel}</div>
<div class="secondary">
<drop-down-search-box items="[[modelList]]"
- selected-item="{{newPrinter.printerModel}}">
+ selected-item="{{newPrinter.ppdModel}}">
</drop-down-search-box>
</div>
</div>
@@ -335,8 +335,8 @@
$i18n{cancelButtonText}
</paper-button>
<paper-button class="action-button" id="addPrinterButton"
- disabled="[[!canAddPrinter_(newPrinter.printerManufacturer,
- newPrinter.printerModel,
+ disabled="[[!canAddPrinter_(newPrinter.ppdManufacturer,
+ newPrinter.ppdModel,
newPrinter.printerPPDPath)]]"
on-tap="switchToConfiguringDialog_">
$i18n{addPrinterButtonText}
« no previous file with comments | « no previous file | chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698