chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js - Issue 2962413002: Separate manufacturer and model fields from PPD info

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js

Issue 2962413002: Separate manufacturer and model fields from PPD info (Closed)

Patch Set: clear the right field Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js ('K') | « chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js ('k') | chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc » ('j') | chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js

diff --git a/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js b/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js

index 2a5eb458004af07ad0e6240a560bf8d8aedd7233..2acfcb6400c336ed3ff14984758eb629f5dfa5be 100644

--- a/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js

+++ b/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js

@@ -19,7 +19,9 @@

* printerPPDPath: string,

* printerProtocol: string,

* printerQueue: string,

- * printerStatus: string

+ * printerStatus: string,

+ * ppdManufacturer: string,

michaelpg 2017/07/06 20:10:43 optional nit: keep alphabetical

skau 2017/07/06 21:10:36 Done.

+ * ppdModel: string

* }}

var CupsPrinterInfo;