[Fuchsia] Implements NetworkInterface.list()

[Fuchsia] Implements NetworkInterface.list()

US-241

R=rmacnak@google.com, tkilbourn@google.com

Committed: https://github.com/dart-lang/sdk/commit/e7c96cae8c91be3f6c46db5ecf89006fd85bac27

[zra, 2017-06-30 17:34:14]

zra@google.com changed reviewers:
+ rmacnak@google.com

[tkilbourn, 2017-06-30 17:38:46]

tkilbourn@google.com changed reviewers:
+ tkilbourn@google.com

[tkilbourn, 2017-06-30 17:38:47]

https://codereview.chromium.org/2962383002/diff/1/runtime/bin/socket_base_fuc...
File runtime/bin/socket_base_fuchsia.cc (right):

https://codereview.chromium.org/2962383002/diff/1/runtime/bin/socket_base_fuc...
runtime/bin/socket_base_fuchsia.cc:318: if (get_if_info.n_info == 0) {
this seems like a valid return value; should this just return an empty list in
that case, rather than treating it like an error?

[zra, 2017-06-30 17:42:42]

https://codereview.chromium.org/2962383002/diff/1/runtime/bin/socket_base_fuc...
File runtime/bin/socket_base_fuchsia.cc (right):

https://codereview.chromium.org/2962383002/diff/1/runtime/bin/socket_base_fuc...
runtime/bin/socket_base_fuchsia.cc:318: if (get_if_info.n_info == 0) {
On 2017/06/30 17:38:47, tkilbourn wrote:
> this seems like a valid return value; should this just return an empty list in
> that case, rather than treating it like an error?

Done.

[rmacnak, 2017-06-30 17:49:38]

lgtm

[tkilbourn, 2017-06-30 17:50:18]

lgtm

[zra, 2017-06-30 17:54:12]

Description was changed from

==========
[Fuchsia] Implements NetworkInterface.list()

US-241
==========

to

==========
[Fuchsia] Implements NetworkInterface.list()

US-241

R=rmacnak@google.com, tkilbourn@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e7c96cae8c91be3f6c46db5ecf89006fd85bac27
==========

[zra, 2017-06-30 17:54:13]

Committed patchset #3 (id:40001) manually as
e7c96cae8c91be3f6c46db5ecf89006fd85bac27.