Implement Dart VM option '--trace_sim_after' in DBC simulator

Implement Dart VM option '--trace_sim_after' in DBC simulator

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/b04b95cfd2b735eff2058b8dc90ea2653a1aea43

[alexmarkov, 2017-06-30 16:18:46]

Patchset #2 (id:20001) has been deleted

[alexmarkov, 2017-06-30 16:20:27]

Description was changed from

==========
Dart VM option '--trace_sim_after' is implemented in DBC simulator
==========

to

==========
Implement Dart VM option '--trace_sim_after' in DBC simulator
==========

[alexmarkov, 2017-06-30 16:21:00]

alexmarkov@google.com changed reviewers:
+ zra@google.com

[zra, 2017-06-30 18:59:14]

https://codereview.chromium.org/2962353003/diff/1/runtime/vm/simulator_dbc.h
File runtime/vm/simulator_dbc.h (right):

https://codereview.chromium.org/2962353003/diff/1/runtime/vm/simulator_dbc.h#...
runtime/vm/simulator_dbc.h:96: uint64_t icount_;
We don't need this field in a PRODUCT build. You can exclude it with:

NOT_IN_PRODUCT(uint64_t icount_);

https://codereview.chromium.org/2962353003/diff/1/runtime/vm/simulator_dbc.h#...
runtime/vm/simulator_dbc.h:166: bool IsTracingExecution() const;
ditto

https://codereview.chromium.org/2962353003/diff/1/runtime/vm/simulator_dbc.h#...
runtime/vm/simulator_dbc.h:169: void TraceInstruction(uint32_t* pc) const;
ditto

[alexmarkov, 2017-06-30 21:53:52]

Fixed review comments.

[zra, 2017-06-30 22:08:42]

lgtm w/ nits.

https://codereview.chromium.org/2962353003/diff/40001/runtime/vm/simulator_db...
File runtime/vm/simulator_dbc.cc (right):

https://codereview.chromium.org/2962353003/diff/40001/runtime/vm/simulator_db...
runtime/vm/simulator_dbc.cc:578: 
Two newlines between functions in source files.

https://codereview.chromium.org/2962353003/diff/40001/runtime/vm/simulator_db...
runtime/vm/simulator_dbc.cc:597: 
ditto

[alexmarkov, 2017-06-30 22:29:14]

Description was changed from

==========
Implement Dart VM option '--trace_sim_after' in DBC simulator
==========

to

==========
Implement Dart VM option '--trace_sim_after' in DBC simulator

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b04b95cfd2b735eff2058b8dc90ea2653a1aea43
==========

[alexmarkov, 2017-06-30 22:29:15]

Committed patchset #2 (id:40001) manually as
b04b95cfd2b735eff2058b8dc90ea2653a1aea43 (presubmit successful).

[alexmarkov, 2017-06-30 23:02:00]

https://codereview.chromium.org/2962353003/diff/1/runtime/vm/simulator_dbc.h
File runtime/vm/simulator_dbc.h (right):

https://codereview.chromium.org/2962353003/diff/1/runtime/vm/simulator_dbc.h#...
runtime/vm/simulator_dbc.h:96: uint64_t icount_;
On 2017/06/30 18:59:14, zra wrote:
> We don't need this field in a PRODUCT build. You can exclude it with:
> 
> NOT_IN_PRODUCT(uint64_t icount_);

Done.

https://codereview.chromium.org/2962353003/diff/1/runtime/vm/simulator_dbc.h#...
runtime/vm/simulator_dbc.h:166: bool IsTracingExecution() const;
On 2017/06/30 18:59:14, zra wrote:
> ditto

Done.

https://codereview.chromium.org/2962353003/diff/1/runtime/vm/simulator_dbc.h#...
runtime/vm/simulator_dbc.h:169: void TraceInstruction(uint32_t* pc) const;
On 2017/06/30 18:59:14, zra wrote:
> ditto

Done.

https://codereview.chromium.org/2962353003/diff/40001/runtime/vm/simulator_db...
File runtime/vm/simulator_dbc.cc (right):

https://codereview.chromium.org/2962353003/diff/40001/runtime/vm/simulator_db...
runtime/vm/simulator_dbc.cc:578: 
On 2017/06/30 22:08:42, zra wrote:
> Two newlines between functions in source files.

Done.

https://codereview.chromium.org/2962353003/diff/40001/runtime/vm/simulator_db...
runtime/vm/simulator_dbc.cc:597: 
On 2017/06/30 22:08:41, zra wrote:
> ditto

Done.