Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

Issue 2962353002: Add probe for V8.Complie (Closed)
Patch Set: update Todos Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/PerformanceMonitor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
index 3b1a8dfec5b4a353f5ff09d14852ee28ecd8cbee..6ead9d2c3879c9d4f2c1f44dc6d1841628b06de3 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
@@ -465,6 +465,12 @@ v8::MaybeLocal<v8::Script> V8ScriptRunner::CompileScript(
"v8,devtools.timeline", "v8.compile", "fileName", file_name.Utf8(),
"data",
InspectorCompileScriptEvent::Data(file_name, script_start_position));
+ // TODO(maxlg): probe will use a execution context once
+ // DocumentWriteEvaluator::EnsureEvaluationContext provide script state, see
+ // https://crbug.com/746961.
+ probe::V8Compile probe(nullptr, file_name,
+ script_start_position.line_.ZeroBasedInt(),
+ script_start_position.column_.ZeroBasedInt());
DCHECK(!streamer || resource);
DCHECK(!resource || resource->CacheHandler() == cache_handler);
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/PerformanceMonitor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698