Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp

Issue 2962353002: Add probe for V8.Complie (Closed)
Patch Set: fix tests Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp
index 55c122b77e8cdeae05eca2992af524ca0483f86f..4e139e0e88fff30a85b4ca97f9f669d893feb852 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp
@@ -150,7 +150,7 @@ TEST_F(ScriptStreamingTest, CompilingStreamedScript) {
EXPECT_TRUE(source_code.Streamer());
v8::TryCatch try_catch(scope.GetIsolate());
v8::Local<v8::Script> script;
- EXPECT_TRUE(V8ScriptRunner::CompileScript(source_code, scope.GetIsolate(),
+ EXPECT_TRUE(V8ScriptRunner::CompileScript(scope.GetScriptState(), source_code,
kSharableCrossOrigin,
kV8CacheOptionsDefault)
.ToLocal(&script));
@@ -190,8 +190,8 @@ TEST_F(ScriptStreamingTest, CompilingStreamedScriptWithParseError) {
EXPECT_TRUE(source_code.Streamer());
v8::TryCatch try_catch(scope.GetIsolate());
v8::Local<v8::Script> script;
- EXPECT_FALSE(V8ScriptRunner::CompileScript(source_code, scope.GetIsolate(),
- kSharableCrossOrigin,
+ EXPECT_FALSE(V8ScriptRunner::CompileScript(scope.GetScriptState(),
+ source_code, kSharableCrossOrigin,
kV8CacheOptionsDefault)
.ToLocal(&script));
EXPECT_TRUE(try_catch.HasCaught());
@@ -343,7 +343,7 @@ TEST_F(ScriptStreamingTest, ScriptsWithSmallFirstChunk) {
EXPECT_TRUE(source_code.Streamer());
v8::TryCatch try_catch(scope.GetIsolate());
v8::Local<v8::Script> script;
- EXPECT_TRUE(V8ScriptRunner::CompileScript(source_code, scope.GetIsolate(),
+ EXPECT_TRUE(V8ScriptRunner::CompileScript(scope.GetScriptState(), source_code,
kSharableCrossOrigin,
kV8CacheOptionsDefault)
.ToLocal(&script));
@@ -380,7 +380,7 @@ TEST_F(ScriptStreamingTest, EncodingChanges) {
EXPECT_TRUE(source_code.Streamer());
v8::TryCatch try_catch(scope.GetIsolate());
v8::Local<v8::Script> script;
- EXPECT_TRUE(V8ScriptRunner::CompileScript(source_code, scope.GetIsolate(),
+ EXPECT_TRUE(V8ScriptRunner::CompileScript(scope.GetScriptState(), source_code,
kSharableCrossOrigin,
kV8CacheOptionsDefault)
.ToLocal(&script));
@@ -418,7 +418,7 @@ TEST_F(ScriptStreamingTest, EncodingFromBOM) {
EXPECT_TRUE(source_code.Streamer());
v8::TryCatch try_catch(scope.GetIsolate());
v8::Local<v8::Script> script;
- EXPECT_TRUE(V8ScriptRunner::CompileScript(source_code, scope.GetIsolate(),
+ EXPECT_TRUE(V8ScriptRunner::CompileScript(scope.GetScriptState(), source_code,
kSharableCrossOrigin,
kV8CacheOptionsDefault)
.ToLocal(&script));

Powered by Google App Engine
This is Rietveld 408576698