Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp

Issue 2962353002: Add probe for V8.Complie (Closed)
Patch Set: remove implementation Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
index 841caa9ce459d7a23d16eb62c38af0a3a5b875f0..712e7b0956d7ba884d0bc7eb6da4cbf9fc2174e7 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
@@ -127,8 +127,9 @@ v8::Local<v8::Value> ScriptController::ExecuteScriptAndReturnValue(
try_catch.SetVerbose(true);
v8::Local<v8::Script> script;
- if (!V8ScriptRunner::CompileScript(source, GetIsolate(),
- access_control_status, v8_cache_options)
+ if (!V8ScriptRunner::CompileScript(
+ ExecutionContext::From(ToScriptStateForMainWorld(GetFrame())),
haraken 2017/07/17 16:16:24 This won't give you a correct context. You'll nee
Liquan (Max) Gu 2017/07/17 20:39:52 Thanks!
+ source, GetIsolate(), access_control_status, v8_cache_options)
.ToLocal(&script))
return result;

Powered by Google App Engine
This is Rietveld 408576698