MD Bookmarks: Add 'show in folder' command to search result context menu

chrome/browser/resources/md_bookmarks/command_manager.js

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Element which shows context menus and handles keyboard
  * shortcuts.
  */
 cr.define('bookmarks', function() {
 
   var CommandManager = Polymer({
     is: 'bookmarks-command-manager',
 
     behaviors: [
       bookmarks.StoreClient,
     ],
 
     properties: {
       /** @private {!Array<Command>} */
       menuCommands_: {
         type: Array,
         value: function() {
           return [
             Command.EDIT,
             Command.COPY_URL,
+            Command.SHOW_IN_FOLDER,
             Command.DELETE,
             // <hr>
             Command.OPEN_NEW_TAB,
             Command.OPEN_NEW_WINDOW,
             Command.OPEN_INCOGNITO,
           ];
         },
       },
 
       /** @private {Set<string>} */
@@ skipping 155 matching lines @@
      *     menu.
      */
     isCommandVisible_: function(command, itemIds) {
       switch (command) {
         case Command.EDIT:
           return itemIds.size == 1 && this.globalCanEdit_;
         case Command.COPY_URL:
           return this.isSingleBookmark_(itemIds);
         case Command.DELETE:
           return itemIds.size > 0 && this.globalCanEdit_;
+        case Command.SHOW_IN_FOLDER:
+          // Hack: We only want this command to appear for list items (not
+          // sidebar folders) while a search is active. This works because right
+          // clicking a sidebar node will select that folder, clearing the
+          // search before the menu is displayed.

[calamity, 2017/07/10 05:51:38]

Why not add a source to openCommandMenuAtPostion/Element? This hack is a bit too
implicit for my liking.

[tsergeant, 2017/07/11 02:58:59]

Done. I've added a MenuSource to the list for determining why it was opened.
It's not a perfect system still (it doesn't work for keyboard shortcuts,
really), but it's enough for what we need now.

+          return itemIds.size == 1 && this.getState().search.term != '' &&
+              !this.containsMatchingNode_(itemIds, function(node) {
+                return !node.parentId || node.parentId == ROOT_NODE_ID;
+              });
         case Command.OPEN_NEW_TAB:
         case Command.OPEN_NEW_WINDOW:
         case Command.OPEN_INCOGNITO:
           return itemIds.size > 0;
         default:
           return false;
       }
     },
 
     /**
@@ skipping 44 matching lines @@
                   Promise.resolve(loadTimeData.getString('toastUrlCopied'));
             } else {
               labelPromise = cr.sendWithPromise(
                   'getPluralString', 'toastItemsCopied', idList.length);
             }
 
             this.showTitleToast_(
                 labelPromise, state.nodes[idList[0]].title, false);
           }.bind(this));
           break;
+        case Command.SHOW_IN_FOLDER:
+          var id = Array.from(itemIds)[0];
+          this.dispatch(bookmarks.actions.selectFolder(
+              assert(state.nodes[id].parentId), state.nodes));
+          break;
         case Command.DELETE:
           var idList = Array.from(this.minimizeDeletionSet_(itemIds));
           var title = state.nodes[idList[0]].title;
           var labelPromise = cr.sendWithPromise(
               'getPluralString', 'toastItemsDeleted', idList.length);
           chrome.bookmarkManagerPrivate.removeTrees(idList, function() {
             this.showTitleToast_(labelPromise, title, true);
           }.bind(this));
           break;
         case Command.UNDO:
@@ skipping 220 matching lines @@
           var id = Array.from(this.menuIds_)[0];
           var itemUrl = this.getState().nodes[id].url;
           label = itemUrl ? 'menuEdit' : 'menuRename';
           break;
         case Command.COPY_URL:
           label = 'menuCopyURL';
           break;
         case Command.DELETE:
           label = 'menuDelete';
           break;
+        case Command.SHOW_IN_FOLDER:
+          label = 'menuShowInFolder';
+          break;
         case Command.OPEN_NEW_TAB:
           label = multipleNodes ? 'menuOpenAllNewTab' : 'menuOpenNewTab';
           break;
         case Command.OPEN_NEW_WINDOW:
           label = multipleNodes ? 'menuOpenAllNewWindow' : 'menuOpenNewWindow';
           break;
         case Command.OPEN_INCOGNITO:
           label = multipleNodes ? 'menuOpenAllIncognito' : 'menuOpenIncognito';
           break;
       }
@@ skipping 129 matching lines @@
 
   /** @return {!bookmarks.CommandManager} */
   CommandManager.getInstance = function() {
     return assert(CommandManager.instance_);
   };
 
   return {
     CommandManager: CommandManager,
   };
 });