Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 296213005: Various extensions to types (Closed)

Created:
6 years, 7 months ago by rossberg
Modified:
6 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -143 lines) Patch
M src/conversions.h View 1 chunk +11 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/types.h View 12 chunks +100 lines, -39 lines 0 comments Download
M src/types.cc View 11 chunks +118 lines, -64 lines 0 comments Download
M src/types-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-types.cc View 19 chunks +86 lines, -38 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rossberg
6 years, 7 months ago (2014-05-23 12:23:36 UTC) #1
Benedikt Meurer
LGTM
6 years, 7 months ago (2014-05-26 04:04:32 UTC) #2
rossberg
6 years, 7 months ago (2014-05-26 13:11:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21494 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698