Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 296213004: Linux Breakpad: Do not pass the Linux distro to non-browser processes. (Closed)

Created:
6 years, 7 months ago by Lei Zhang
Modified:
6 years, 7 months ago
Reviewers:
mdempsky
CC:
chromium-reviews, jochen (gone - plz use gerrit)
Visibility:
Public.

Description

Linux Breakpad: Do not pass the Linux distro to non-browser processes. After r271640, they no longer need this information, since the browser process sets it in crash reports. TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272713

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -20 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 5 chunks +9 lines, -12 lines 0 comments Download
M components/breakpad/app/breakpad_linux.cc View 1 chunk +2 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Lei Zhang
6 years, 7 months ago (2014-05-23 05:50:34 UTC) #1
mdempsky
lgtm Nice.
6 years, 7 months ago (2014-05-23 05:59:04 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-23 05:59:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/296213004/20001
6 years, 7 months ago (2014-05-23 06:00:58 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 07:55:47 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 08:01:02 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/69435)
6 years, 7 months ago (2014-05-23 08:01:03 UTC) #7
Lei Zhang
jochen: Can you do a breakpad OWNERS review? Hmm, I thought if you are in ...
6 years, 7 months ago (2014-05-23 08:11:20 UTC) #8
Lei Zhang
On 2014/05/23 08:11:20, Lei Zhang wrote: > jochen: Can you do a breakpad OWNERS review? ...
6 years, 7 months ago (2014-05-24 04:55:42 UTC) #9
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-05-24 04:56:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/296213004/20001
6 years, 7 months ago (2014-05-24 04:56:35 UTC) #11
mdempsky
On 2014/05/24 04:55:42, Lei Zhang wrote: > ... because my email address is misspelled in ...
6 years, 7 months ago (2014-05-24 05:16:02 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 12:26:54 UTC) #13
Message was sent while issue was closed.
Change committed as 272713

Powered by Google App Engine
This is Rietveld 408576698