Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: tools/perf/benchmarks/system_health_smoke_test.py

Issue 2962123002: Disabled flaky system health smoke test. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Run all system health stories used by system health benchmarks. 5 """Run all system health stories used by system health benchmarks.
6 6
7 Only memory benchmarks are used when running these stories to make the total 7 Only memory benchmarks are used when running these stories to make the total
8 cycle time manageable. Other system health benchmarks should be using the same 8 cycle time manageable. Other system health benchmarks should be using the same
9 stories as memory ones, only with fewer actions (no memory dumping). 9 stories as memory ones, only with fewer actions (no memory dumping).
10 """ 10 """
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 # crbug.com/699966 67 # crbug.com/699966
68 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.multitab:misc:typical24', # pylint: disable=line-too-long 68 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.multitab:misc:typical24', # pylint: disable=line-too-long
69 # crbug.com/725923 69 # crbug.com/725923
70 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:social:facebook', # pylint: disable=line-too-long 70 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:social:facebook', # pylint: disable=line-too-long
71 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:media:flickr', # pylint: disable=line-too-long 71 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:media:flickr', # pylint: disable=line-too-long
72 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:social:tumblr', # pylint: disable=line-too-long 72 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:social:tumblr', # pylint: disable=line-too-long
73 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:social:twitter', # pylint: disable=line-too-long 73 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:social:twitter', # pylint: disable=line-too-long
74 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.load:social:facebook', # pylint: disable=line-too-long 74 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.load:social:facebook', # pylint: disable=line-too-long
75 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.load:social:tumblr', # pylint: disable=line-too-long 75 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.load:social:tumblr', # pylint: disable=line-too-long
76 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.load:social:pinterest', # pylint: disable=line-too-long 76 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.load:social:pinterest', # pylint: disable=line-too-long
77 # crbug.com/725386
78 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.browse:social:twitter', # pylint: disable=line-too-long
77 }) 79 })
78 80
79 81
80 def _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test): 82 def _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test):
81 83
82 # NOTE TO SHERIFFS: DO NOT DISABLE THIS TEST. 84 # NOTE TO SHERIFFS: DO NOT DISABLE THIS TEST.
83 # 85 #
84 # This smoke test dynamically tests all system health user stories. So 86 # This smoke test dynamically tests all system health user stories. So
85 # disabling it for one failing or flaky benchmark would disable a much 87 # disabling it for one failing or flaky benchmark would disable a much
86 # wider swath of coverage than is usally intended. Instead, if a test is 88 # wider swath of coverage than is usally intended. Instead, if a test is
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 # Prefetch WPR archive needed by the stories set to avoid race condition 173 # Prefetch WPR archive needed by the stories set to avoid race condition
172 # when feching them when tests are run in parallel. 174 # when feching them when tests are run in parallel.
173 # See crbug.com/700426 for more details. 175 # See crbug.com/700426 for more details.
174 stories_set.wpr_archive_info.DownloadArchivesIfNeeded() 176 stories_set.wpr_archive_info.DownloadArchivesIfNeeded()
175 177
176 for story_to_smoke_test in stories_set.stories: 178 for story_to_smoke_test in stories_set.stories:
177 suite.addTest( 179 suite.addTest(
178 _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test)) 180 _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test))
179 181
180 return suite 182 return suite
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698