Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceServerTiming.cpp

Issue 2962113002: Updates to Server-Timing in accordance with with spec changes (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/timing/PerformanceServerTiming.cpp
diff --git a/third_party/WebKit/Source/core/timing/PerformanceServerTiming.cpp b/third_party/WebKit/Source/core/timing/PerformanceServerTiming.cpp
index 120613c1a004af37ed673a7f47916b422cc173e1..8e9435f88aef633dbff6f79d1c5745688e1b65f1 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceServerTiming.cpp
+++ b/third_party/WebKit/Source/core/timing/PerformanceServerTiming.cpp
@@ -3,20 +3,19 @@
// found in the LICENSE file.
#include "core/timing/PerformanceServerTiming.h"
-
#include "bindings/core/v8/V8ObjectBuilder.h"
-#include "core/timing/PerformanceBase.h"
#include "platform/wtf/text/WTFString.h"
namespace blink {
-PerformanceServerTiming::PerformanceServerTiming(const String& name,
- const String& metric,
- double duration,
- const String& description)
- : PerformanceEntry(name, "server", 0.0, duration),
- metric_(metric),
- description_(description) {}
+PerformanceServerTiming::PerformanceServerTiming(const String& metric,
+ double value,
+ const String& description,
+ bool allow_timing_details)
+ : metric_(metric),
+ value_(value),
+ description_(description),
+ allow_timing_details_(allow_timing_details) {}
PerformanceServerTiming::~PerformanceServerTiming() {}
@@ -24,13 +23,17 @@ String PerformanceServerTiming::metric() const {
return metric_;
}
+double PerformanceServerTiming::value() const {
+ return allow_timing_details_ ? value_ : 0.0;
+}
+
String PerformanceServerTiming::description() const {
- return description_;
+ return allow_timing_details_ ? description_ : "";
}
void PerformanceServerTiming::BuildJSONValue(V8ObjectBuilder& builder) const {
- PerformanceEntry::BuildJSONValue(builder);
builder.AddString("metric", metric());
+ builder.AddNumber("value", value());
builder.AddString("description", description());
}

Powered by Google App Engine
This is Rietveld 408576698