Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceBase.h

Issue 2962113002: Updates to Server-Timing in accordance with with spec changes (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/timing/PerformanceBase.h
diff --git a/third_party/WebKit/Source/core/timing/PerformanceBase.h b/third_party/WebKit/Source/core/timing/PerformanceBase.h
index ff36a6a3212ed1df661c166637ca66358b665b7b..b423e382ae1ee159a584b96fc1a56aca61e07ab1 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceBase.h
+++ b/third_party/WebKit/Source/core/timing/PerformanceBase.h
@@ -39,6 +39,7 @@
#include "core/timing/PerformanceEntry.h"
#include "core/timing/PerformanceNavigationTiming.h"
#include "core/timing/PerformancePaintTiming.h"
+#include "core/timing/PerformanceServerTiming.h"
#include "platform/Timer.h"
#include "platform/heap/Handle.h"
#include "platform/wtf/Forward.h"
@@ -58,6 +59,8 @@ class UserTiming;
using PerformanceEntryVector = HeapVector<Member<PerformanceEntry>>;
using PerformanceObservers = HeapListHashSet<Member<PerformanceObserver>>;
+using PerformanceServerTimingVector =
+ HeapVector<Member<PerformanceServerTiming>>;
Yoav Weiss 2017/06/29 06:57:33 Remove the definition from here.
class CORE_EXPORT PerformanceBase : public EventTargetWithInlineData {
@@ -112,12 +115,6 @@ class CORE_EXPORT PerformanceBase : public EventTargetWithInlineData {
void AddResourceTiming(const ResourceTimingInfo&);
- enum class ShouldAddToBuffer {
- Always,
- Never,
- };
- void AddServerTiming(const ResourceResponse&, ShouldAddToBuffer);
-
void NotifyNavigationTimingToObservers();
void AddFirstPaintTiming(double start_time);
@@ -143,6 +140,9 @@ class CORE_EXPORT PerformanceBase : public EventTargetWithInlineData {
const ResourceResponse&,
const SecurityOrigin&,
ExecutionContext*);
+ static PerformanceServerTimingVector ParseServerTiming(
+ const ResourceTimingInfo&,
+ bool allowTimingDetails);
DECLARE_VIRTUAL_TRACE();
@@ -179,7 +179,6 @@ class CORE_EXPORT PerformanceBase : public EventTargetWithInlineData {
unsigned frame_timing_buffer_size_;
PerformanceEntryVector resource_timing_buffer_;
unsigned resource_timing_buffer_size_;
- PerformanceEntryVector server_timing_buffer_;
Member<PerformanceEntry> navigation_timing_;
Member<UserTiming> user_timing_;
Member<PerformanceEntry> first_paint_timing_;

Powered by Google App Engine
This is Rietveld 408576698