Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: content/renderer/layout_test_dependencies.h

Issue 2962073002: OOPIF support for layout test pixel dumps.
Patch Set: Rebasing on top of 8bc8e844008b (still works locally). Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/render_thread_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/layout_test_dependencies.h
diff --git a/content/renderer/layout_test_dependencies.h b/content/renderer/layout_test_dependencies.h
index df8feefe2447de3cdebfd1b674d6e18d992c8b25..030a713a291e0538a7072a6a60939893feb7bbb6 100644
--- a/content/renderer/layout_test_dependencies.h
+++ b/content/renderer/layout_test_dependencies.h
@@ -11,33 +11,21 @@
#include "base/memory/ref_counted.h"
namespace cc {
-class ContextProvider;
class CopyOutputRequest;
-class LayerTreeFrameSink;
class SwapPromise;
}
-namespace gpu {
-class GpuChannelHost;
-class GpuMemoryBufferManager;
-}
-
namespace content {
-class CompositorDependencies;
// This class allows injection of LayoutTest-specific behaviour to the
// RenderThreadImpl.
class LayoutTestDependencies {
public:
- virtual std::unique_ptr<cc::LayerTreeFrameSink> CreateLayerTreeFrameSink(
- int32_t routing_id,
- scoped_refptr<gpu::GpuChannelHost> gpu_channel,
- scoped_refptr<cc::ContextProvider> compositor_context_provider,
- scoped_refptr<cc::ContextProvider> worker_context_provider,
- gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager,
- CompositorDependencies* deps) = 0;
-
// Returns a SwapPromise which should be queued for the next compositor frame.
+ // DO NOT SUBMIT: This method (and the whole class) should be removed. We
+ // should wait for SubmitCompositorFrame in the browser process (e.g. see the
+ // comment from kenrb@ in SurfaceHitTestReadyNotifier::WaitForSurfaceReady)
+ // rather than waiting in the renderer.
virtual std::unique_ptr<cc::SwapPromise> RequestCopyOfOutput(
int32_t routing_id,
std::unique_ptr<cc::CopyOutputRequest> request) = 0;
« no previous file with comments | « no previous file | content/renderer/render_thread_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698