Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5514)

Unified Diff: chrome/browser/cocoa/tab_view.h

Issue 2962018: Respect Spaces when dragging tabs on OS X (Closed)
Patch Set: Fix up comments Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/cocoa/tab_view.mm » ('j') | chrome/browser/cocoa/tab_view.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/tab_view.h
diff --git a/chrome/browser/cocoa/tab_view.h b/chrome/browser/cocoa/tab_view.h
index 0e1149f86ce297497d78448da1f98f8d70dbd885..6d4898e353193c127264db1521b91f95e2a6ce74 100644
--- a/chrome/browser/cocoa/tab_view.h
+++ b/chrome/browser/cocoa/tab_view.h
@@ -6,6 +6,9 @@
#define CHROME_BROWSER_COCOA_TAB_VIEW_H_
#import <Cocoa/Cocoa.h>
+#include <ApplicationServices/ApplicationServices.h>
+
+#include <map>
#include "base/scoped_nsobject.h"
#import "chrome/browser/cocoa/background_gradient_view.h"
@@ -81,6 +84,12 @@ enum AlertState {
TabWindowController* draggedController_; // weak. Controller being dragged.
NSWindow* dragWindow_; // weak. The window being dragged
NSWindow* dragOverlay_; // weak. The overlay being dragged
+ // Cache workspace IDs per-drag because computing them on 10.5 with
+ // CGWindowListCreateDescriptionFromArray is expensive.
+ // resetDragControllers clears this cache.
+ //
+ // TODO(davidben): When 10.5 becomes unsupported, remove this.
+ std::map<CGWindowID, int> workspaceIDCache_;
TabWindowController* targetController_; // weak. Controller being targeted
NSCellStateValue state_;
« no previous file with comments | « no previous file | chrome/browser/cocoa/tab_view.mm » ('j') | chrome/browser/cocoa/tab_view.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698