Print Preview: Update test to check parameters sent to print()

chrome/test/data/webui/print_preview/print_preview_tests.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('print_preview_test', function() {
   /**
    * Index of the "Save as PDF" printer.
    * @type {number}
    * @const
    */
@@ skipping 127 matching lines @@
                 is_default: true
               }
             ]
           }
         }
       }
     };
   }
 
   /**
+   * Get the default media size for |device|.
+   * @param {!print_preview.PrinterCapabilitiesResponse} device
+   * @return {width_microns: number,

[dpapad, 2017/06/28 01:28:34]

Nit: return {{...}}

I think there is a set of brackets here, and at line 1339. (We don't compile
tests, so it is not actually causing any problem).

[rbpotter, 2017/06/28 02:36:27]

Done.

+   *          height_microns: number} The width and height of the default
+   *     media.
+   */
+  function getDefaultMediaSize(device) {
+    var size = device.capabilities.printer.media_size.option.find(
+        function(opt) { return opt.is_default; });
+    return { width_microns: size.width_microns,
+             height_microns: size.height_microns };
+  }
+
+  /**
+   * Get the default page orientation for |device|.
+   * @param {!print_preview.PrinterCapabilitiesResponse} device
+   * @return {string} The default orientation.
+   */
+  function getDefaultOrientation(device) {
+    return device.capabilities.printer.page_orientation.option.find(
+        function(opt) { return opt.is_default; }).type;
+  }
+
+
+  /**
    * @param {string} printerId
    * @return {!Object}
    */
   function getCddTemplateWithAdvancedSettings(printerId) {
     var template = getCddTemplate(printerId);
     template.capabilities.printer.vendor_capability = [{
       display_name: 'Print Area',
       id: 'Print Area',
       type: 'SELECT',
       select_cap: {
@@ skipping 1128 matching lines @@
             expectedMessageStart));
         expectTrue(printButton.disabled);
 
         // Select a new destination
         var barDestination =
             printPreview.destinationStore_.destinations().find(
                 function(d) {
                   return d.id == 'BarDevice';
                 });
 
-        nativeLayer.setLocalDestinationCapabilities(
-            getCddTemplate('BarDevice'));
+        var barDevice = getCddTemplate('BarDevice');
+        nativeLayer.setLocalDestinationCapabilities(barDevice);
         printPreview.destinationStore_.selectDestination(barDestination);
 
         return nativeLayer.whenCalled('getPrinterCapabilities', 'BarDevice')
             .then(function() {
               // Dispatch event indicating new preview has loaded.
               var previewDoneEvent = new Event(
                   print_preview.PreviewArea.EventType.PREVIEW_GENERATION_DONE);
               previewArea.dispatchEvent(previewDoneEvent);
 
               // Has active print button and successfully 'prints', indicating
               // recovery from error state.
               expectFalse(printButton.disabled);
               printButton.click();
               // This should result in a call to print.
-              return nativeLayer.whenCalled('print');
+              return nativeLayer.whenCalled('print').then(
+                  /**
+                   * @param {destination: !print_preview.Destination,
+                   *         printTicketStore: !print_preview.PrintTicketStore,
+                   *         cloudPrintInterface: print_preview
+                   *                                  .CloudPrintInterface,
+                   *         documentInfo: print_preview.DocumentInfo} args
+                   *      The arguments that print() was called with.
+                   */
+                  function(args) {
+                    // Sanity check some printing argument values.
+                    var printTicketStore = args.printTicketStore;
+                    expectEquals(args.destination.id, barDevice.printerId);
+                    expectEquals(printTicketStore.landscape.getValue(),

[dpapad, 2017/06/28 01:28:34]

Nit: According to the docs, expected value goes first, then actual value, see
[1]

https://cs.chromium.org/chromium/src/chrome/test/data/webui/test_api.js?l=886...
(expectEquals is just a wrapper around assertEquals).

[rbpotter, 2017/06/28 02:36:27]

Done.

+                        getDefaultOrientation(barDevice) == 'LANDSCAPE');
+                    expectEquals(printTicketStore.copies.getValueAsNumber(), 1);
+                    var media_default = getDefaultMediaSize(barDevice);

[dpapad, 2017/06/28 01:28:34]

s/media_default/mediaDefault

[rbpotter, 2017/06/28 02:36:27]

Done.

+                    expectEquals(
+                        printTicketStore.mediaSize.getValue().width_microns,
+                        media_default.width_microns);
+                    expectEquals(
+                        printTicketStore.mediaSize.getValue().height_microns,
+                        media_default.height_microns);
+                  });
             });
       });
     });
 
     // Test the preview generator to make sure the generate draft parameter is
     // set correctly. It should be false if the only change is the page range.
     test('GenerateDraft', function() {
       // Use a real preview generator.
       previewArea.previewGenerator_ =
           new print_preview.PreviewGenerator(printPreview.destinationStore_,
@@ skipping 45 matching lines @@
       return setupSettingsAndDestinationsWithCapabilities().then(function() {
         // The system default destination should be used instead of the
         // most recent destination.
         assertEquals(
             'FooDevice',
             printPreview.destinationStore_.selectedDestination.id);
       });
     });
   });
 });