Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: chromeos/components/tether/initializer.cc

Issue 2961733002: [CrOS Tether] Remove spammy log from Initializer. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/components/tether/initializer.cc
diff --git a/chromeos/components/tether/initializer.cc b/chromeos/components/tether/initializer.cc
index 9b446e0ccdc938f1fa4cabac1e4761cb0158116b..838e87969cefd5ba50f8c41e832b492f6e86cc6b 100644
--- a/chromeos/components/tether/initializer.cc
+++ b/chromeos/components/tether/initializer.cc
@@ -64,17 +64,16 @@ void Initializer::Init(
NetworkConnectionHandler* network_connection_handler) {
if (!device::BluetoothAdapterFactory::IsBluetoothSupported()) {
PA_LOG(WARNING) << "Bluetooth is not supported on this device; cannot "
- << "initialize tether feature.";
+ << "initialize Tether feature.";
return;
}
if (instance_) {
- PA_LOG(WARNING) << "Tether initialization was triggered when the feature "
- << "had already been initialized; exiting initialization "
- << "early.";
+ // The Tether feature has already been initialized. No need to do anything.
return;
}
+ PA_LOG(INFO) << "Initializer Tether feature.";
Ryan Hansberry 2017/06/26 23:55:08 Is this log needed? If so, the phrasing is awkward
Kyle Horimoto 2017/06/27 00:56:01 Fixed typo. Yes, I think this log is useful. There
instance_ =
new Initializer(cryptauth_service, std::move(notification_presenter),
pref_service, token_service, network_state_handler,
« chrome/browser/chromeos/tether/tether_service.cc ('K') | « chromeos/components/tether/initializer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698