[CrOS Tether] Remove spammy log from Initializer.

chrome/browser/chromeos/tether/tether_service.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/tether/tether_service.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
@@ skipping 180 matching lines @@
   UpdateTetherTechnologyState();
 }
 
 bool TetherService::HasSyncedTetherHosts() const {
   return !cryptauth_service_->GetCryptAuthDeviceManager()
               ->GetTetherHosts()
               .empty();
 }
 
 void TetherService::UpdateTetherTechnologyState() {
-  chromeos::NetworkStateHandler::TechnologyState tether_technology_state =
+  bool was_tether_enabled = network_state_handler_->IsTechnologyEnabled(
+      chromeos::NetworkTypePattern::Tether());
+
+  chromeos::NetworkStateHandler::TechnologyState new_tether_technology_state =
       GetTetherTechnologyState();
 
-  network_state_handler_->SetTetherTechnologyState(tether_technology_state);
+  network_state_handler_->SetTetherTechnologyState(new_tether_technology_state);
 
-  if (tether_technology_state ==
-      chromeos::NetworkStateHandler::TechnologyState::TECHNOLOGY_ENABLED) {
+  if (!was_tether_enabled &&

[Ryan Hansberry, 2017/06/26 23:55:08]

Please add a test.

[Kyle Horimoto, 2017/06/27 00:56:01]

Added tests. When testing, I realized that this isn't actually correct all the
time. When changes occur as part of the tether toggle changing in settings, this
would not start/stop at the right time. Kept tests though.

+      new_tether_technology_state ==
+          chromeos::NetworkStateHandler::TechnologyState::TECHNOLOGY_ENABLED) {
+    // Start if the feature is enabled and was not previously running.
     StartTetherIfEnabled();
-  } else {
+  } else if (was_tether_enabled &&
+             new_tether_technology_state !=
+                 chromeos::NetworkStateHandler::TechnologyState::
+                     TECHNOLOGY_ENABLED) {
+    // Stop if the feature is not enabled and was previously running.
     StopTether();
   }
 }
 
 chromeos::NetworkStateHandler::TechnologyState
 TetherService::GetTetherTechnologyState() {
   if (shut_down_ || suspended_ || session_manager_client_->IsScreenLocked() ||
       !HasSyncedTetherHosts()) {
     return chromeos::NetworkStateHandler::TechnologyState::
         TECHNOLOGY_UNAVAILABLE;
@@ skipping 37 matching lines @@
               chromeos::NetworkTypePattern::Cellular()));
 }
 
 bool TetherService::IsAllowedByPolicy() const {
   return profile_->GetPrefs()->GetBoolean(prefs::kInstantTetheringAllowed);
 }
 
 bool TetherService::IsEnabledbyPreference() const {
   return profile_->GetPrefs()->GetBoolean(prefs::kInstantTetheringEnabled);
 }