Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 296173011: Cleanup: fix Namespace comments in /extension/commons (Closed)

Created:
6 years, 7 months ago by Yeun
Modified:
6 years, 7 months ago
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Namespace comments fixes in /extension/commons to comply Chrome style standards. Changes: 1) dom_action_types.h 2) install_warning.h Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272847

Patch Set 1 : Namespace should be terminated with "// namespace extensions" #

Patch Set 2 : Non-const references clean-up in value_builder #

Patch Set 3 : #

Patch Set 4 : Revert my changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M extensions/common/dom_action_types.h View 2 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/install_warning.h View 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
Yeun
6 years, 7 months ago (2014-05-23 23:17:03 UTC) #1
Yeun
6 years, 7 months ago (2014-05-25 03:23:51 UTC) #2
Yeun
On 2014/05/25 03:23:51, Yeun wrote: When I had typed `git cl upload`, following message was ...
6 years, 7 months ago (2014-05-25 03:36:51 UTC) #3
limasdf
On 2014/05/25 03:36:51, Yeun wrote: > On 2014/05/25 03:23:51, Yeun wrote: > > When I ...
6 years, 7 months ago (2014-05-25 10:30:14 UTC) #4
Yeun
On 2014/05/25 10:30:14, limasdf wrote: > On 2014/05/25 03:36:51, Yeun wrote: > > On 2014/05/25 ...
6 years, 7 months ago (2014-05-25 11:34:17 UTC) #5
koz (OOO until 15th September)
lgtm
6 years, 7 months ago (2014-05-25 23:28:32 UTC) #6
Yeun
The CQ bit was checked by lauren.yeun.kim@gmail.com
6 years, 7 months ago (2014-05-25 23:56:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lauren.yeun.kim@gmail.com/296173011/40001
6 years, 7 months ago (2014-05-25 23:57:04 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-26 01:54:19 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-26 02:15:59 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/188100)
6 years, 7 months ago (2014-05-26 02:16:00 UTC) #11
Yeun
On 2014/05/26 02:16:00, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 7 months ago (2014-05-26 02:24:45 UTC) #12
koz (OOO until 15th September)
On 2014/05/26 02:24:45, Yeun wrote: > On 2014/05/26 02:16:00, I haz the power (commit-bot) wrote: ...
6 years, 7 months ago (2014-05-26 02:47:45 UTC) #13
Yeun
On 2014/05/26 02:47:45, koz wrote: > On 2014/05/26 02:24:45, Yeun wrote: > > On 2014/05/26 ...
6 years, 7 months ago (2014-05-26 06:53:52 UTC) #14
Yeun
The CQ bit was checked by lauren.yeun.kim@gmail.com
6 years, 7 months ago (2014-05-26 06:54:31 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lauren.yeun.kim@gmail.com/296173011/60001
6 years, 7 months ago (2014-05-26 06:54:44 UTC) #16
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 16:25:50 UTC) #17
Message was sent while issue was closed.
Change committed as 272847

Powered by Google App Engine
This is Rietveld 408576698