|
|
Created:
6 years, 7 months ago by Yeun Modified:
6 years, 7 months ago Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionNamespace comments fixes in /extension/commons to comply Chrome style standards.
Changes:
1) dom_action_types.h
2) install_warning.h
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272847
Patch Set 1 : Namespace should be terminated with "// namespace extensions" #Patch Set 2 : Non-const references clean-up in value_builder #Patch Set 3 : #Patch Set 4 : Revert my changes. #
Messages
Total messages: 17 (0 generated)
On 2014/05/25 03:23:51, Yeun wrote: When I had typed `git cl upload`, following message was displayed. > This branch is associated with issue 296173011. Adding patch to that issue. I think that I have to upload a new patch set that includes patch set 1 and 2. Is it right? Sorry for bothering you and thanks.
On 2014/05/25 03:36:51, Yeun wrote: > On 2014/05/25 03:23:51, Yeun wrote: > > When I had typed `git cl upload`, following message was displayed. > > > This branch is associated with issue 296173011. Adding patch to that issue. > > > I think that I have to upload a new patch set that includes patch set 1 and 2. > Is it right? > > Sorry for bothering you and thanks. @Yeun, > I think that I have to upload a new patch set that includes patch set 1 and 2. > Is it right? Right, The last Patch Set will be reviewed & submitted. And you don't actually need to add two reviewer. just one reviwer is enough. Because they have same role in this CL(Change List). Plus, Could you clarify your commit description ? > Cleanup coding style from extension/commons/. BUG=None
On 2014/05/25 10:30:14, limasdf wrote: > On 2014/05/25 03:36:51, Yeun wrote: > > On 2014/05/25 03:23:51, Yeun wrote: > > > > When I had typed `git cl upload`, following message was displayed. > > > > > This branch is associated with issue 296173011. Adding patch to that issue. > > > > > > I think that I have to upload a new patch set that includes patch set 1 and 2. > > Is it right? > > > > Sorry for bothering you and thanks. > > @Yeun, > > I think that I have to upload a new patch set that includes patch set 1 and 2. > > Is it right? > > Right, The last Patch Set will be reviewed & submitted. > > And you don't actually need to add two reviewer. just one reviwer is enough. > Because they have same role in this CL(Change List). > > Plus, Could you clarify your commit description ? > > > Cleanup coding style from extension/commons/. > BUG=None I just modify the description and added finnur as my reviewer. Thanks for your kind response.
lgtm
The CQ bit was checked by lauren.yeun.kim@gmail.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lauren.yeun.kim@gmail.com/296173011/40001
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are real, and report flakes to chrome-troopers@google.com. The failing builders are: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...) android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...) linux_chromium_chromeos_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...) linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...) linux_chromium_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...) linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...) mac_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...) mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...) win_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...) win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...) win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...) linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/8995) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/12079)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
On 2014/05/26 02:16:00, I haz the power (commit-bot) wrote: > Try jobs failed on following builders: > android_dbg on tryserver.chromium > (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...) It looks like I have made some mistakes. I just downloaded this patch to other mac and started ninja build again. If I find some mistakes, I'll upload antother patch set. Sorry.
On 2014/05/26 02:24:45, Yeun wrote: > On 2014/05/26 02:16:00, I haz the power (commit-bot) wrote: > > Try jobs failed on following builders: > > android_dbg on tryserver.chromium > > > (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...) > > It looks like I have made some mistakes. I just downloaded this patch to other > mac and started ninja build again. If I find some mistakes, I'll upload antother > patch set. > > Sorry. No need to apologize, this is very normal :-) Looks like the problem is that you're now calling .Build() on a const builder, but Build() is not a const function. To fix just revert your changes to value_builder.h and .cc.
On 2014/05/26 02:47:45, koz wrote: > On 2014/05/26 02:24:45, Yeun wrote: > > On 2014/05/26 02:16:00, I haz the power (commit-bot) wrote: > > > Try jobs failed on following builders: > > > android_dbg on tryserver.chromium > > > > > > (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...) > > > > It looks like I have made some mistakes. I just downloaded this patch to other > > mac and started ninja build again. If I find some mistakes, I'll upload > antother > > patch set. > > > > Sorry. > No need to apologize, this is very normal :-) > > Looks like the problem is that you're now calling .Build() on a const builder, > but Build() is not a const function. To fix just revert your changes to > value_builder.h and .cc. Thanks. I reverted my changes. Although the patch set 3 has the problems, the build passed. I think my command is not enough to test my patch set. How can I build correctly? ----- $time ninja -C out/Debug chrome ninja: Entering directory `out/Debug' [11076/15286] LIBTOOL-STATIC libcdm_common.a, POSTBUILDS warning: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: warning for library: libcdm_common.a the table of contents is empty (no object file members in the library define global symbols) [12623/15286] LIBTOOL-STATIC libcdm_renderer.a, POSTBUILDS warning: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool: warning for library: libcdm_renderer.a the table of contents is empty (no object file members in the library define global symbols) [15217/15286] SOLINK "Chromium Framework.framework/Versions/A/Chromium Framework", POSTBUILDS [15286/15286] STAMP Chromium.app real 288m18.380s user 520m19.432s sys 60m28.048s
The CQ bit was checked by lauren.yeun.kim@gmail.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lauren.yeun.kim@gmail.com/296173011/60001
Message was sent while issue was closed.
Change committed as 272847 |