|
|
Created:
6 years, 7 months ago by dzhioev (left Google) Modified:
6 years, 7 months ago Reviewers:
Nikita (slow) CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionAdded ability to use new GAIA endpoint on CrOS login screen.
This feature can be enabled with "enable-embedded-singin" command-line switch.
BUG=308312
TEST=manually
NOTRY=true
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272971
Patch Set 1 #Patch Set 2 : Rebased on ToT. #Patch Set 3 : Rebased again. #
Messages
Total messages: 21 (0 generated)
Hi, please review.
lgtm
The CQ bit was checked by dzhioev@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/296173008/1
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are real, and report flakes to chrome-troopers@google.com. The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...) android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...) chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...) linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...) linux_chromium_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...) linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...) linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...) mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...) win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...) linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...) linux_chromium_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...) linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
The CQ bit was checked by dzhioev@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/296173008/1
The CQ bit was checked by dzhioev@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/296173008/20001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for chromeos/chromeos_switches.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file chromeos/chromeos_switches.cc Hunk #2 FAILED at 28. Hunk #3 succeeded at 62 (offset 4 lines). Hunk #4 succeeded at 92 (offset 4 lines). Hunk #5 succeeded at 125 (offset 4 lines). Hunk #6 succeeded at 150 (offset 4 lines). Hunk #7 succeeded at 197 (offset 4 lines). 1 out of 7 hunks FAILED -- saving rejects to file chromeos/chromeos_switches.cc.rej Patch: chromeos/chromeos_switches.cc Index: chromeos/chromeos_switches.cc diff --git a/chromeos/chromeos_switches.cc b/chromeos/chromeos_switches.cc index e5836867bf330322ba7d2d0569c024f744d7cf95..d1c151f3cb40c7e71f9307ad573b61d3f26fa84d 100644 --- a/chromeos/chromeos_switches.cc +++ b/chromeos/chromeos_switches.cc @@ -8,15 +8,15 @@ namespace chromeos { namespace switches { // Path for app's OEM manifest file. -const char kAppOemManifestFile[] = "app-mode-oem-manifest"; +const char kAppOemManifestFile[] = "app-mode-oem-manifest"; // When wallpaper boot animation is not disabled this switch // is used to override OOBE/sign in WebUI init type. // Possible values: parallel|postpone. Default: parallel. -const char kAshWebUIInit[] = "ash-webui-init"; +const char kAshWebUIInit[] = "ash-webui-init"; // Specifies the URL of the consumer device management backend. -const char kConsumerDeviceManagementUrl[] = "consumer-device-management-url"; +const char kConsumerDeviceManagementUrl[] = "consumer-device-management-url"; // Forces the stub implementation of dbus clients. const char kDbusStub[] = "dbus-stub"; @@ -28,22 +28,22 @@ const char kDerelictDetectionTimeout[] = "derelict-detection-timeout"; const char kDerelictIdleTimeout[] = "derelict-idle-timeout"; // Disables wallpaper boot animation (except of OOBE case). -const char kDisableBootAnimation[] = "disable-boot-animation"; +const char kDisableBootAnimation[] = "disable-boot-animation"; // Disables the ChromeOS demo. -const char kDisableDemoMode[] = "disable-demo-mode"; +const char kDisableDemoMode[] = "disable-demo-mode"; // Disable Genius App and use the original Help App instead. -const char kDisableGeniusApp[] = "disable-genius-app"; +const char kDisableGeniusApp[] = "disable-genius-app"; // Avoid doing expensive animations upon login. -const char kDisableLoginAnimations[] = "disable-login-animations"; +const char kDisableLoginAnimations[] = "disable-login-animations"; // Disable new channel switcher UI. -const char kDisableNewChannelSwitcherUI[] = "disable-new-channel-switcher-ui"; +const char kDisableNewChannelSwitcherUI[] = "disable-new-channel-switcher-ui"; // Disables new Kiosk UI when kiosk apps are represented as user pods. -const char kDisableNewKioskUI[] = "disable-new-kiosk-ui"; +const char kDisableNewKioskUI[] = "disable-new-kiosk-ui"; // Disable Quickoffice component app thus handlers won't be registered so // it will be possible to install another version as normal app for testing. @@ -58,21 +58,25 @@ const char kDisableNetworkPortalNotification[] = "disable-network-portal-notification"; // Enables switching between different cellular carriers from the UI. -const char kEnableCarrierSwitching[] = "enable-carrier-switching"; +const char kEnableCarrierSwitching[] = "enable-carrier-switching"; // Enables the next generation version of ChromeVox. Only valid with // use_chromevox_next=1 within your GYP_DEFINES. -const char kEnableChromeVoxNext[] = "enable-chromevox-next"; +const char kEnableChromeVoxNext[] = "enable-chromevox-next"; // Enables consumer management, which allows user to enroll, remotely lock and // locate the device. -const char kEnableConsumerManagement[] = "enable-consumer-management"; +const char kEnableConsumerManagement[] = "enable-consumer-management"; + +// If this switch is set, Chrome OS login screen uses |EmbeddedSignin| endpoint +// of GAIA. +const char kEnableEmbeddedSignin[] = "enable-embedded-signin"; // Enables MTP support in Files.app. const char kEnableFileManagerMTP[] = "enable-filemanager-mtp"; // Enable explicit HID detection on OOBE. -const char kEnableHIDDetectionOnOOBE[] = "enable-hid-detection-on-oobe"; +const char kEnableHIDDetectionOnOOBE[] = "enable-hid-detection-on-oobe"; // Enables notifications about captive portals in session. const char kEnableNetworkPortalNotification[] = @@ -84,13 +88,13 @@ const char kEnableTouchpadThreeFingerClick[] // Enable Kiosk mode for ChromeOS. Note this switch refers to retail mode rather // than the kiosk app mode. -const char kEnableKioskMode[] = "enable-kiosk-mode"; +const char kEnableKioskMode[] = "enable-kiosk-mode"; // Enables rollback option for resetting ChromeOS. -const char kEnableRollbackOption[] = "enable-rollback-option"; +const char kEnableRollbackOption[] = "enable-rollback-option"; // Enables request of tablet site (via user agent override). -const char kEnableRequestTabletSite[] = "enable-request-tablet-site"; +const char kEnableRequestTabletSite[] = "enable-request-tablet-site"; // Whether to enable forced enterprise re-enrollment. const char kEnterpriseEnableForcedReEnrollment[] = @@ -117,22 +121,22 @@ const char kFileManagerEnableNewAudioPlayer[] = // Passed to Chrome the first time that it's run after the system boots. // Not passed on restart after sign out. -const char kFirstExecAfterBoot[] = "first-exec-after-boot"; +const char kFirstExecAfterBoot[] = "first-exec-after-boot"; // Usually in browser tests the usual login manager bringup is skipped so that // tests can change how it's brought up. This flag disables that. -const char kForceLoginManagerInTests[] = "force-login-manager-in-tests"; +const char kForceLoginManagerInTests[] = "force-login-manager-in-tests"; // Indicates that the browser is in "browse without sign-in" (Guest session) // mode. Should completely disable extensions, sync and bookmarks. -const char kGuestSession[] = "bwsi"; +const char kGuestSession[] = "bwsi"; // If true, the Chromebook has a Chrome OS keyboard. Don't use the flag for // Chromeboxes. -const char kHasChromeOSKeyboard[] = "has-chromeos-keyboard"; +const char kHasChromeOSKeyboard[] = "has-chromeos-keyboard"; // If true, the Chromebook has a keyboard with a diamond key. -const char kHasChromeOSDiamondKey[] = "has-chromeos-diamond-key"; +const char kHasChromeOSDiamondKey[] = "has-chromeos-diamond-key"; // If true, profile selection in UserManager will always return active user's // profile. @@ -142,32 +146,32 @@ const char kIgnoreUserProfileMappingForTests[] = "ignore-user-profile-mapping-for-tests"; // Path for the screensaver used in Kiosk mode -const char kKioskModeScreensaverPath[] = "kiosk-mode-screensaver-path"; +const char kKioskModeScreensaverPath[] = "kiosk-mode-screensaver-path"; // Enables Chrome-as-a-login-manager behavior. -const char kLoginManager[] = "login-manager"; +const char kLoginManager[] = "login-manager"; // Specifies a password to be used to login (along with login-user). -const char kLoginPassword[] = "login-password"; +const char kLoginPassword[] = "login-password"; // Specifies the profile to use once a chromeos user is logged in. This is // required unless --multi-profile is set. -const char kLoginProfile[] = "login-profile"; +const char kLoginProfile[] = "login-profile"; // Specifies the user which is already logged in. -const char kLoginUser[] = "login-user"; +const char kLoginUser[] = "login-user"; // Enables natural scroll by default. -const char kNaturalScrollDefault[] = "enable-natural-scroll-default"; +const char kNaturalScrollDefault[] = "enable-natural-scroll-default"; // Skips all other OOBE pages after user login. -const char kOobeSkipPostLogin[] = "oobe-skip-postlogin"; +const char kOobeSkipPostLogin[] = "oobe-skip-postlogin"; // Interval at which we check for total time on OOBE. -const char kOobeTimerInterval[] = "oobe-timer-interval"; +const char kOobeTimerInterval[] = "oobe-timer-interval"; // Indicates that a guest session has been started before OOBE completion. -const char kOobeGuestSession[] = "oobe-guest-session"; +const char kOobeGuestSession[] = "oobe-guest-session"; // Specifies power stub behavior: // 'cycle=2' - Cycles power states every 2 seconds. @@ -189,15 +193,15 @@ const char kPowerStub[] = "power-stub"; const char kShillStub[] = "shill-stub"; // Sends test messages on first call to RequestUpdate (stub only). -const char kSmsTestMessages[] = "sms-test-messages"; +const char kSmsTestMessages[] = "sms-test-messages"; // Indicates that a stub implementation of CrosSettings that stores settings in // memory without signing should be used, treating current user as the owner. // This option is for testing the chromeos build of chrome on the desktop only. -const char kStubCrosSettings[] = "stub-cros-settings"; +const char kStubCrosSettings[] = "stub-cros-settings"; // Disables SAML sigin support. -const char kDisableSamlSignin[] = "disable-saml-signin"; +const char kDisableSamlSignin[] = "disable-saml-signin"; // Enables animated transitions during first-run tutorial. const char kEnableFirstRunUITransitions[] = "enable-first-run-ui-transitions";
The CQ bit was checked by dzhioev@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/296173008/40001
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are real, and report flakes to chrome-troopers@google.com. The failing builders are: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
The CQ bit was checked by dzhioev@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/296173008/40001
Message was sent while issue was closed.
Change committed as 272971 |