Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 296173008: Added ability to use new GAIA endpoint on CrOS login screen. (Closed)

Created:
6 years, 7 months ago by dzhioev (left Google)
Modified:
6 years, 7 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Added ability to use new GAIA endpoint on CrOS login screen. This feature can be enabled with "enable-embedded-singin" command-line switch. BUG=308312 TEST=manually NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272971

Patch Set 1 #

Patch Set 2 : Rebased on ToT. #

Patch Set 3 : Rebased again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -39 lines) Patch
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 1 chunk +11 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos_switches.cc View 1 2 7 chunks +37 lines, -33 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
dzhioev (left Google)
Hi, please review.
6 years, 7 months ago (2014-05-23 16:17:34 UTC) #1
Nikita (slow)
lgtm
6 years, 7 months ago (2014-05-23 16:22:03 UTC) #2
dzhioev (left Google)
The CQ bit was checked by dzhioev@chromium.org
6 years, 7 months ago (2014-05-23 16:27:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/296173008/1
6 years, 7 months ago (2014-05-23 16:28:01 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 20:33:15 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 20:39:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/69564) linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/30638) linux_chromium_clang_dbg ...
6 years, 7 months ago (2014-05-23 20:39:07 UTC) #7
dzhioev (left Google)
The CQ bit was checked by dzhioev@chromium.org
6 years, 7 months ago (2014-05-26 09:14:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/296173008/1
6 years, 7 months ago (2014-05-26 09:15:19 UTC) #9
dzhioev (left Google)
The CQ bit was checked by dzhioev@chromium.org
6 years, 7 months ago (2014-05-26 09:36:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/296173008/20001
6 years, 7 months ago (2014-05-26 09:37:20 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-26 20:17:36 UTC) #12
commit-bot: I haz the power
Failed to apply patch for chromeos/chromeos_switches.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 7 months ago (2014-05-26 20:17:37 UTC) #13
dzhioev (left Google)
The CQ bit was checked by dzhioev@chromium.org
6 years, 7 months ago (2014-05-27 12:50:23 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/296173008/40001
6 years, 7 months ago (2014-05-27 12:50:48 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-27 14:30:36 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-27 14:35:58 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/77909)
6 years, 7 months ago (2014-05-27 14:35:59 UTC) #18
dzhioev (left Google)
The CQ bit was checked by dzhioev@chromium.org
6 years, 7 months ago (2014-05-27 14:37:56 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/296173008/40001
6 years, 7 months ago (2014-05-27 14:38:34 UTC) #20
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 14:39:18 UTC) #21
Message was sent while issue was closed.
Change committed as 272971

Powered by Google App Engine
This is Rietveld 408576698