Link the contents of tools/valgrind/tsan_v2/suppressions.txt into TSan binaries.

Link the contents of tools/valgrind/tsan_v2/suppressions.txt into TSan binaries.

BUG=302040
R=thakis@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273830

[Alexander Potapenko, 2014-05-23 14:46:15]

Please take a look.
I'm also adding a script to a new tools/memory dir. I'm planning to add OWNERS
and README for that dir in a separate CL and migrate the contents of
tools/valgrind there.

[Alexander Potapenko, 2014-05-23 15:09:59]

On 2014/05/23 14:46:15, Alexander Potapenko wrote:
> Please take a look.
> I'm also adding a script to a new tools/memory dir. I'm planning to add OWNERS
> and README for that dir in a separate CL and migrate the contents of
> tools/valgrind there.

Adding tools/memory in https://codereview.chromium.org/293983023

[Alexander Potapenko, 2014-05-27 15:35:24]

A friendly ping.

On Fri, May 23, 2014 at 7:09 PM,  <glider@chromium.org> wrote:
> On 2014/05/23 14:46:15, Alexander Potapenko wrote:
>>
>> Please take a look.
>> I'm also adding a script to a new tools/memory dir. I'm planning to add
>> OWNERS
>> and README for that dir in a separate CL and migrate the contents of
>> tools/valgrind there.
>
>
> Adding tools/memory in https://codereview.chromium.org/293983023
>
> https://codereview.chromium.org/296173006/



-- 
Alexander Potapenko
Software Engineer
Google Moscow

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2014-05-27 15:42:30]

Is tools/valgrind/tsan_v2/suppressions.txt used by anything? If not, should we
manually convert it to cc and check that in?

https://codereview.chromium.org/296173006/diff/20001/base/base.gyp
File base/base.gyp (right):

https://codereview.chromium.org/296173006/diff/20001/base/base.gyp#newcode1522
base/base.gyp:1522: 'message': 'generating suppressions header from <(infile)',
header?

https://codereview.chromium.org/296173006/diff/20001/tools/memory/suppression...
File tools/memory/suppression_string_gen.sh (right):

https://codereview.chromium.org/296173006/diff/20001/tools/memory/suppression...
tools/memory/suppression_string_gen.sh:11: 
set -eu?

[Alexander Potapenko, 2014-05-28 10:34:38]

Isn't it more convenient for the people to edit a .txt file?
Right now one can also pass it in TSAN_OPTIONS to add new suppressions without
recompilation (if needed).

https://codereview.chromium.org/296173006/diff/20001/base/base.gyp
File base/base.gyp (right):

https://codereview.chromium.org/296173006/diff/20001/base/base.gyp#newcode1522
base/base.gyp:1522: 'message': 'generating suppressions header from <(infile)',
On 2014/05/27 15:42:30, Nico (traveling) wrote:
> header?

Used to be a header. Fixed.

https://codereview.chromium.org/296173006/diff/20001/tools/memory/suppression...
File tools/memory/suppression_string_gen.sh (right):

https://codereview.chromium.org/296173006/diff/20001/tools/memory/suppression...
tools/memory/suppression_string_gen.sh:11: 
On 2014/05/27 15:42:30, Nico (traveling) wrote:
> set -eu?

Done.

[Nico, 2014-05-28 10:56:32]

lgtm for now

On 2014/05/28 10:34:38, Alexander Potapenko wrote:
> Isn't it more convenient for the people to edit a .txt file?

Yes, but if that's the only reason for having a txt file I probably wouldn't
have one. With a cc file, editing isn't much harder, and it makes it clear to
folks that this is compiled into the binary. Else, folks might edit the txt file
and rerun, and wonder why their change is ignored. So maybe consider checking in
the generated cc file and remove the text file.

> Right now one can also pass it in TSAN_OPTIONS to add new suppressions without
> recompilation (if needed).
> 
> https://codereview.chromium.org/296173006/diff/20001/base/base.gyp
> File base/base.gyp (right):
> 
> https://codereview.chromium.org/296173006/diff/20001/base/base.gyp#newcode1522
> base/base.gyp:1522: 'message': 'generating suppressions header from
<(infile)',
> On 2014/05/27 15:42:30, Nico (traveling) wrote:
> > header?
> 
> Used to be a header. Fixed.
> 
>
https://codereview.chromium.org/296173006/diff/20001/tools/memory/suppression...
> File tools/memory/suppression_string_gen.sh (right):
> 
>
https://codereview.chromium.org/296173006/diff/20001/tools/memory/suppression...
> tools/memory/suppression_string_gen.sh:11: 
> On 2014/05/27 15:42:30, Nico (traveling) wrote:
> > set -eu?
> 
> Done.

[Alexander Potapenko, 2014-05-28 15:33:13]

Removed the generation step.
I wonder if there're projects that do not link to base:sanitizer_options. In
that case we won't be able to remove suppressions.txt
(running a tryjob to check that)

[Alexander Potapenko, 2014-05-28 19:36:49]

On 2014/05/28 15:33:13, Alexander Potapenko wrote:
> Removed the generation step.
> I wonder if there're projects that do not link to base:sanitizer_options. In
> that case we won't be able to remove suppressions.txt
> (running a tryjob to check that)

Ok, bot failures are unrelated, committing.

[Alexander Potapenko, 2014-05-28 19:36:55]

The CQ bit was checked by glider@chromium.org

[commit-bot: I haz the power, 2014-05-28 19:38:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/glider@chromium.org/296173006/80001

[commit-bot: I haz the power, 2014-05-28 23:09:53]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[commit-bot: I haz the power, 2014-05-28 23:13:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-28 23:13:37]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[Alexander Potapenko, 2014-05-30 09:29:05]

The CQ bit was checked by glider@chromium.org

[commit-bot: I haz the power, 2014-05-30 09:30:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/glider@chromium.org/296173006/100001

[Alexander Potapenko, 2014-05-30 11:27:35]

The CQ bit was checked by glider@chromium.org

[commit-bot: I haz the power, 2014-05-30 11:28:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/glider@chromium.org/296173006/110001

[commit-bot: I haz the power, 2014-05-30 15:00:30]

Change committed as 273830