Issue 2961723002: Remove hack from KernelTypePromoter.isPromotionCandidate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2961723002: Remove hack from KernelTypePromoter.isPromotionCandidate. (Closed)

Created:
3 years, 5 months ago by Paul Berry

Modified:
3 years, 5 months ago

Reviewers:
ahe, scheglov

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Remove hack from KernelTypePromoter.isPromotionCandidate. All variable declarations encountered by type inference are now of type KernelVariableDeclaration, so we no longer need a hack to handle ordinary VariableDeclaration objects. Removing the hack avoids covering up bugs. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/fc32e0e72b572ff42de9651fdd3c5e400b49dd1f

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -9 lines)			Patch
	M	pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart	View		1 chunk	+3 lines, -9 lines	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

3 years, 5 months ago (2017-06-27 13:00:11 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fc32e0e72b572ff42de9651fdd3c5e400b49dd1f (presubmit successful).