Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2961693002: Add listener calls to ThisExpression and KernelTypeLiteral. (Closed)

Created:
3 years, 5 months ago by Paul Berry
Modified:
3 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add listener calls to ThisExpression and KernelTypeLiteral. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/d13f09c9e0a2cdf5cb0789f7c220c83ceb723e39

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 2 chunks +11 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inference_listener.dart View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 5 months ago (2017-06-26 20:38:55 UTC) #2
scheglov
LGTM
3 years, 5 months ago (2017-06-26 20:40:47 UTC) #3
Paul Berry
3 years, 5 months ago (2017-06-26 20:45:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d13f09c9e0a2cdf5cb0789f7c220c83ceb723e39 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698