cc: HUD handle context lost in Gpu raster.

cc/trees/layer_tree_host_impl.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/layer_tree_host_impl.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 1683 matching lines @@
   }
 
   {
     TRACE_EVENT0("cc", "DrawLayers.FrameViewerTracing");
     TRACE_EVENT_OBJECT_SNAPSHOT_WITH_ID(
         frame_viewer_instrumentation::kCategoryLayerTree,
         "cc::LayerTreeHostImpl", id_, AsValueWithFrame(frame));
   }
 
   const DrawMode draw_mode = GetDrawMode();
+  uint32_t evict_res_id = 0U;

[vmpstr, 2017/06/30 23:16:51]

ResourceId? also evict_resource_id.

[sohan, 2017/07/04 16:51:13]

Done.

 
   // Because the contents of the HUD depend on everything else in the frame, the
   // contents of its texture are updated as the last thing before the frame is
   // drawn.
   if (active_tree_->hud_layer()) {
     TRACE_EVENT0("cc", "DrawLayers.UpdateHudTexture");
-    active_tree_->hud_layer()->UpdateHudTexture(
+    // For Ganesh backed HUD, a context loss may cause the drawing canvas to be
+    // invalid, return the resource id to evicted from quadlist.
+    evict_res_id = active_tree_->hud_layer()->UpdateHudTexture(
         draw_mode, resource_provider_.get(),
         layer_tree_frame_sink_->context_provider());
   }
 
   CompositorFrameMetadata metadata = MakeCompositorFrameMetadata();
   metadata.may_contain_video = frame->may_contain_video;
   metadata.activation_dependencies = std::move(frame->activation_dependencies);
   active_tree()->FinishSwapPromises(&metadata);
   for (auto& latency : metadata.latency_info) {
     TRACE_EVENT_WITH_FLOW1("input,benchmark", "LatencyInfo.Flow",
                            TRACE_ID_DONT_MANGLE(latency.trace_id()),
                            TRACE_EVENT_FLAG_FLOW_IN | TRACE_EVENT_FLAG_FLOW_OUT,
                            "step", "SwapBuffers");
     // Only add the latency component once for renderer swap, not the browser
     // swap.
     if (!latency.FindLatency(ui::INPUT_EVENT_LATENCY_RENDERER_SWAP_COMPONENT, 0,
                              nullptr)) {
       latency.AddLatencyNumber(ui::INPUT_EVENT_LATENCY_RENDERER_SWAP_COMPONENT,
                                0, 0);
     }
   }
 
   // Collect all resource ids in the render passes into a single array.
   ResourceProvider::ResourceIdArray resources;
   for (const auto& render_pass : frame->render_passes) {
     for (auto* quad : render_pass->quad_list) {
-      for (ResourceId resource_id : quad->resources)
-        resources.push_back(resource_id);
+      for (ResourceId resource_id : quad->resources) {
+        if (resource_id != evict_res_id) {

[vmpstr, 2017/06/30 23:16:51]

This doesn't look right. 

The resource should not be in the quad list if it's evicted. Maybe check this
during HUDLayerImpl::AppendQuads instead and keep all of the logic limited to
that class?

[sohan, 2017/07/04 16:51:13]

Yeah this is kinda odd.
The problem is for HUD layers, append quad happens before sksurface creation (in
UpdateHudTexture for ganesh backend) and if the context loss happens during
surface creation, we are stuck with the resource in quad list.
We can of course traverse the renderpass and evict, but thought it is more
efficient to avoid passing to resource array here. wdyt ?

+          resources.push_back(resource_id);
+        }
+      }
     }
   }
 
   DCHECK_LE(BeginFrameArgs::kStartingFrameNumber,
             frame->begin_frame_ack.sequence_number);
   metadata.begin_frame_ack = frame->begin_frame_ack;
 
   CompositorFrame compositor_frame;
   compositor_frame.metadata = std::move(metadata);
   resource_provider_->PrepareSendToParent(resources,
@@ skipping 2565 matching lines @@
 
 void LayerTreeHostImpl::ShowScrollbarsForImplScroll(ElementId element_id) {
   if (!element_id)
     return;
   if (ScrollbarAnimationController* animation_controller =
           ScrollbarAnimationControllerForElementId(element_id))
     animation_controller->DidScrollUpdate();
 }
 
 }  // namespace cc